Skip to content

Commit c1e6547

Browse files
Shouyan guoGitHub Enterprise
authored andcommitted
make async commit configurable (pingcap#3)
1 parent 0f26142 commit c1e6547

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

br/pkg/lightning/config/config.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ const (
7575
defaultChecksumTableConcurrency = 2
7676
defaultTableConcurrency = 6
7777
defaultIndexConcurrency = 2
78+
defaultEnableAsyncCommit = "ON"
7879

7980
// defaultMetaSchemaName is the default database name used to store lightning metadata
8081
defaultMetaSchemaName = "lightning_metadata"
@@ -134,6 +135,7 @@ type DBStore struct {
134135
BuildStatsConcurrency int `toml:"build-stats-concurrency" json:"build-stats-concurrency"`
135136
IndexSerialScanConcurrency int `toml:"index-serial-scan-concurrency" json:"index-serial-scan-concurrency"`
136137
ChecksumTableConcurrency int `toml:"checksum-table-concurrency" json:"checksum-table-concurrency"`
138+
EnableAsyncCommit string `toml:"enable-async-commit" json:"enable-async-commit"`
137139
Vars map[string]string `toml:"-" json:"vars"`
138140
}
139141

@@ -712,6 +714,7 @@ func NewConfig() *Config {
712714
DistSQLScanConcurrency: defaultDistSQLScanConcurrency,
713715
IndexSerialScanConcurrency: defaultIndexSerialScanConcurrency,
714716
ChecksumTableConcurrency: defaultChecksumTableConcurrency,
717+
EnableAsyncCommit: defaultEnableAsyncCommit,
715718
},
716719
Cron: Cron{
717720
SwitchMode: Duration{Duration: 5 * time.Minute},
@@ -1045,6 +1048,9 @@ func (cfg *Config) DefaultVarsForImporterAndLocalBackend() {
10451048
if cfg.TiDB.ChecksumTableConcurrency == 0 {
10461049
cfg.TiDB.ChecksumTableConcurrency = defaultChecksumTableConcurrency
10471050
}
1051+
if len(cfg.TiDB.EnableAsyncCommit) == 0 {
1052+
cfg.TiDB.EnableAsyncCommit = defaultEnableAsyncCommit
1053+
}
10481054
}
10491055

10501056
func (cfg *Config) CheckAndAdjustTiDBPort(ctx context.Context, mustHaveInternalConnections bool) error {

br/pkg/lightning/restore/tidb.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ func DBFromConfig(ctx context.Context, dsn config.DBStore) (*sql.DB, error) {
8585
"tidb_distsql_scan_concurrency": strconv.Itoa(dsn.DistSQLScanConcurrency),
8686
"tidb_index_serial_scan_concurrency": strconv.Itoa(dsn.IndexSerialScanConcurrency),
8787
"tidb_checksum_table_concurrency": strconv.Itoa(dsn.ChecksumTableConcurrency),
88+
"tidb_enable_async_commit": dsn.EnableAsyncCommit,
8889

8990
// after https://github.com/pingcap/tidb/pull/17102 merge,
9091
// we need set session to true for insert auto_random value in TiDB Backend

0 commit comments

Comments
 (0)