Remove ForceNew from oauth_token attribute of r/tfe_oauth_client (#1825)

* Remove ForceNew from oauth_token attribute of r/tfe_oauth_client

* Update CHANGELOG

* chore: trigger CI

* chore: trigger CI

Author: lilincmu

CHANGELOG.md

@@ -1,5 +1,8 @@
 ## Unreleased
 
+ENHANCEMENTS:
+* `r/tfe_oauth_client`: The `oauth_token` attribute no longer triggers resource replacement unless combined with other replacement-triggering attributes. Use `terraform apply -replace` to force replacement. By @lilincmu [#1825](https://github.com/hashicorp/terraform-provider-tfe/pull/1825)
+
 ## v0.68.3
 
 BUG FIXES:

internal/provider/resource_tfe_oauth_client.go

@@ -63,7 +63,6 @@ func resourceTFEOAuthClient() *schema.Resource {
 				Type:      schema.TypeString,
 				Optional:  true,
 				Sensitive: true,
-				ForceNew:  true,
 			},
 
 			"private_key": {

internal/provider/resource_tfe_oauth_client_test.go

@@ -172,8 +172,8 @@ func TestAccTFEOAuthClient_updateOAuthTokenID(t *testing.T) {
 					testAccCheckTFEOAuthClientExists("tfe_oauth_client.foobar", oc),
 					resource.TestCheckResourceAttrSet("tfe_oauth_client.foobar", "oauth_token_id"),
 					func(s *terraform.State) error {
-						if initialOAuthTokenID == oc.OAuthTokens[0].ID {
-							return fmt.Errorf("oauth_token_id did not change")
+						if initialOAuthTokenID != oc.OAuthTokens[0].ID {
+							return fmt.Errorf("oauth_token_id changed")
 						}
 						return nil
 					},