Chat feature based on Adenovan's Rechat branch #12667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks for reviving this! There's a few minor things I'd like to tweak and modernize in this code, but I'll take care of it myself and merge later this week. |
|
actually there is more good looking gui that use onscreen touch control on that commit in different branch but its need to recompile atlas tools. and on latest i worked on the chat is on pause screen but this chat use different protocol can reuse the gui if you want |
|
Well dealing with the atlas should be much easier now - the tools are now easily built. I think let's merge this, then we can look at merging your newer GUI after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on @adenovan PR #9090
I only fixed the conflicts and made minor tweaks
PS: There were errors related to missing
releaseButtons()function, i don't know what it is used for, so i removed it LOL :D