Fix car lighting issues in DiRT 2. #13760
Merged
+82
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes waters? |
|
I don't think it fixes water, but I'm not sure. I changed it to "Fixes part of..." so the issue doesn't close. |
hrydgard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #13012 (except on GL ES 2.0 and maybe D3D9) by enabling the features I added to fix Outrun, and fixing a bug.
The effect is similar to Outrun's reflections, but uses a rotated precomputed shine map instead of realtime rendered reflection images.
Also does a bunch of code cleanup and an added feature I used for debugging this - in separate commits to not make the PR too messy.