Skip to content

Commit f93ce6a

Browse files
committed
fix(ingest): include urns in rest sink failure logs (datahub-project#5848)
1 parent 8b17ab9 commit f93ce6a

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

metadata-ingestion/src/datahub/ingestion/sink/datahub_rest.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -175,18 +175,18 @@ def _write_done_callback(
175175
:200
176176
]
177177

178+
# Include information about the entity that failed.
179+
record = record_envelope.record
180+
if isinstance(record, MetadataChangeProposalWrapper):
181+
entity_id = record.entityUrn
182+
e.info["id"] = entity_id
183+
elif isinstance(record, MetadataChangeEvent):
184+
entity_id = record.proposedSnapshot.urn
185+
e.info["id"] = entity_id
186+
178187
if not self.treat_errors_as_warnings:
179188
self.report.report_failure({"error": e.message, "info": e.info})
180189
else:
181-
record = record_envelope.record
182-
if isinstance(record, MetadataChangeProposalWrapper):
183-
# include information about the entity that failed
184-
entity_id = cast(
185-
MetadataChangeProposalWrapper, record
186-
).entityUrn
187-
e.info["id"] = entity_id
188-
else:
189-
entity_id = None
190190
self.report.report_warning({"warning": e.message, "info": e.info})
191191
write_callback.on_failure(record_envelope, e, e.info)
192192
else:

0 commit comments

Comments
 (0)