Merge pull request #203 from robertlich/failure-policy-configurable

set failure policy to be configurable for webhooks

Author: jainishshah17

.github/workflows/pr.yaml

@@ -54,7 +54,7 @@ jobs:
         run: |
           kind load docker-image $IMAGE --name=chart-testing
           helm install $USER chart/tugger --debug --wait \
-            --set=createMutatingWebhook=true \
+            --set=mutatingWebhook.create=true \
             --set=image.tag=latest
 
       - name: Test Mutation

README.md

@@ -67,8 +67,8 @@ helm install --name tugger \
   --set docker.registryUrl=jainishshah17, \
   --set whitelistNamespaces={kube-system,default}, \
   --set whitelistRegistries={jainishshah17} \
-  --set createValidatingWebhook=true \
-  --set createMutatingWebhook=true \
+  --set validatingWebhook.create=true \
+  --set mutatingWebhook.create=true \
   tugger/tugger
 ```
 

chart/tugger/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v1
 appVersion: "0.1.8"
 description: A Helm chart for Tugger
 name: tugger
-version: 0.4.5
+version: 0.4.6
 keywords:
 - DevOps
 - helm

chart/tugger/ci/lint-values.yaml

@@ -1,6 +1,8 @@
 # enables optional features in the chart so they will be linted in the PR test
-createValidatingWebhook: true
-createMutatingWebhook: true
+validatingWebhook:
+  create: true
+mutatingWebhook:
+  create: true
 env: prod
 docker:
   ifExists: true

chart/tugger/templates/admission-registration.yaml

@@ -13,7 +13,7 @@
   {{ $caCert = $ca.Cert }}
 {{- end }}
 
-{{- if .Values.createValidatingWebhook }}
+{{- if or .Values.createValidatingWebhook .Values.validatingWebhook.create}}
 ---
 apiVersion: admissionregistration.k8s.io/v1
 kind: ValidatingWebhookConfiguration
@@ -42,7 +42,7 @@ webhooks:
     resources:
     - pods
     scope: "Namespaced"
-  failurePolicy: Ignore
+  failurePolicy: {{ default "Ignore" .Values.validatingWebhook.failurePolicy }}
   clientConfig:
     service:
       name: {{ $serviceName }}
@@ -52,7 +52,7 @@ webhooks:
     caBundle: {{ b64enc $caCert }}
 {{- end }}
 
-{{- if .Values.createMutatingWebhook }}
+{{- if or .Values.createMutatingWebhook .Values.mutatingWebhook.create }}
 ---
 apiVersion: admissionregistration.k8s.io/v1
 kind: MutatingWebhookConfiguration
@@ -76,7 +76,7 @@ webhooks:
     apiGroups: [""]
     apiVersions: ["v1"]
     resources: ["pods"]
-  failurePolicy: Ignore
+  failurePolicy: {{ default "Ignore" .Values.mutatingWebhook.failurePolicy }}
   clientConfig:
     service:
       name: {{ $serviceName }}

chart/tugger/values.yaml

@@ -70,8 +70,12 @@ namespaceSelector:
   #   operator: NotIn
   #   values: ["0","1"]
 
-createValidatingWebhook: false
-createMutatingWebhook: false
+validatingWebhook:
+  create: false
+  failurePolicy: #default: Ignore, options: Ignore, Fail
+mutatingWebhook:
+  create: false
+  failurePolicy: #default: Ignore, options: Ignore, Fail
 
 resources: {}
   # We usually recommend not to specify default resources and to leave this as a conscious