chore: update github.com/kelindar/async to v1.3.1 and refactor timing functions in benchmarks

kelindar · kelindar · commit bed8cfa9ceaa · 2025-06-20T01:26:38.000+04:00
diff --git a/go.mod b/go.mod
@@ -5,7 +5,7 @@ go 1.24.2
 toolchain go1.24.4
 
 require (
-	github.com/kelindar/async v1.3.0
+	github.com/kelindar/async v1.3.1
 	github.com/kelindar/s3 v0.0.3
 	github.com/klauspost/compress v1.18.0
 	github.com/stretchr/testify v1.10.0
diff --git a/go.sum b/go.sum
@@ -2,8 +2,8 @@ github.com/RoaringBitmap/roaring v0.6.1 h1:O36Tdaj1Fi/zyr25shTHwlQPGdq53+u4WkM08
 github.com/RoaringBitmap/roaring v0.6.1/go.mod h1:WZ83fjBF/7uBHi6QoFyfGL4+xuV4Qn+xFkm4+vSzrhE=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
-github.com/kelindar/async v1.3.0 h1:mPBTJ/eXCKE+HHKfY1r68Wjo1KjSyArajlsipcSajEY=
-github.com/kelindar/async v1.3.0/go.mod h1:gaCq2zl7zDKjlPY05R45l/0hHgVkJxsfjR3X7sxxvDg=
+github.com/kelindar/async v1.3.1 h1:UL+s/40S/ikNxBkAiqLmtfgcrHxVdk2mvzYneJxc7Xg=
+github.com/kelindar/async v1.3.1/go.mod h1:gaCq2zl7zDKjlPY05R45l/0hHgVkJxsfjR3X7sxxvDg=
 github.com/kelindar/s3 v0.0.3 h1:izXVdKkH7faO1vM+qQ1zSA9Y6L/8C8p2CkF/FIrnUa0=
 github.com/kelindar/s3 v0.0.3/go.mod h1:O2/uN3efPfCUVNmNPHNBY242Bm7LIu+RHQ7bDU5iUXs=
 github.com/klauspost/compress v1.18.0 h1:c/Cqfb0r+Yi+JtIEq73FWXVkRonBlf0CRNYc8Zttxdo=
diff --git a/tales.go b/tales.go
@@ -52,7 +52,7 @@ type Service struct {
 	metaLRU  *cache.LRU[string, *codec.Metadata]
 	commands chan command
 	jobs     chan async.Task[iter.Seq[codec.LogEntry]]
-	consumer async.Task[iter.Seq[codec.LogEntry]]
+	consumer async.Awaiter
 	wg       sync.WaitGroup
 	cancel   context.CancelFunc
 	closed   int32 // atomic flag
@@ -161,7 +161,7 @@ func (l *Service) Close() error {
 
 	// Stop worker pool
 	close(l.jobs)
-	l.consumer.Outcome()
+	l.consumer.Wait()
 
 	// Signal the run loop to exit and wait for it to finish
 	close(l.commands)
diff --git a/tales_test.go b/tales_test.go
@@ -27,18 +27,16 @@ func BenchmarkLog(b *testing.B) {
 
 	count := 0
 	start := time.Now()
-	for time.Now().Sub(start) < time.Second {
+	for time.Since(start) < time.Second {
 		const interval = 50 * time.Millisecond
-		for i := time.Now(); time.Now().Sub(i) < interval; {
+		for i := time.Now(); time.Since(i) < interval; {
 			logger.Log("hello world", 1)
 			count++
 		}
 
 		logger.flush()
 	}
-
-	b.N = count
-	b.ReportMetric(float64(count)/time.Now().Sub(start).Seconds(), "tps")
+	b.ReportMetric(float64(count)/time.Since(start).Seconds(), "tps")
 }
 
 /*
@@ -60,18 +58,17 @@ func BenchmarkQuery(b *testing.B) {
 	b.ResetTimer()
 	count := 0
 	start := time.Now()
-	for time.Now().Sub(start) < time.Second {
+	for time.Since(start) < time.Second {
 		const interval = 50 * time.Millisecond
-		for i := time.Now(); time.Now().Sub(i) < interval; {
+		for i := time.Now(); time.Since(i) < interval; {
 			for range logger.Query(time.Now().Add(-1*time.Hour), time.Now().Add(1*time.Hour), 1) {
 				// Consume the iterator
 			}
 			count++
 		}
 	}
 
-	b.N = count
-	b.ReportMetric(float64(count)/time.Now().Sub(start).Seconds(), "qps")
+	b.ReportMetric(float64(count)/time.Since(start).Seconds(), "qps")
 }
 
 func TestIntegration(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -27,18 +27,16 @@ func BenchmarkLog(b *testing.B) {`
`27`	`27`
`28`	`28`	`count := 0`
`29`	`29`	`start := time.Now()`
`30`		`- for time.Now().Sub(start) < time.Second {`
	`30`	`+ for time.Since(start) < time.Second {`
`31`	`31`	`const interval = 50 * time.Millisecond`
`32`		`- for i := time.Now(); time.Now().Sub(i) < interval; {`
	`32`	`+ for i := time.Now(); time.Since(i) < interval; {`
`33`	`33`	`logger.Log("hello world", 1)`
`34`	`34`	`count++`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`logger.flush()`
`38`	`38`	`}`
`39`		`-`
`40`		`- b.N = count`
`41`		`- b.ReportMetric(float64(count)/time.Now().Sub(start).Seconds(), "tps")`
	`39`	`+ b.ReportMetric(float64(count)/time.Since(start).Seconds(), "tps")`
`42`	`40`	`}`
`43`	`41`
`44`	`42`	`/*`
`@@ -60,18 +58,17 @@ func BenchmarkQuery(b *testing.B) {`
`60`	`58`	`b.ResetTimer()`
`61`	`59`	`count := 0`
`62`	`60`	`start := time.Now()`
`63`		`- for time.Now().Sub(start) < time.Second {`
	`61`	`+ for time.Since(start) < time.Second {`
`64`	`62`	`const interval = 50 * time.Millisecond`
`65`		`- for i := time.Now(); time.Now().Sub(i) < interval; {`
	`63`	`+ for i := time.Now(); time.Since(i) < interval; {`
`66`	`64`	`for range logger.Query(time.Now().Add(-1time.Hour), time.Now().Add(1time.Hour), 1) {`
`67`	`65`	`// Consume the iterator`
`68`	`66`	`}`
`69`	`67`	`count++`
`70`	`68`	`}`
`71`	`69`	`}`
`72`	`70`
`73`		`- b.N = count`
`74`		`- b.ReportMetric(float64(count)/time.Now().Sub(start).Seconds(), "qps")`
	`71`	`+ b.ReportMetric(float64(count)/time.Since(start).Seconds(), "qps")`
`75`	`72`	`}`
`76`	`73`
`77`	`74`	`func TestIntegration(t *testing.T) {`