feat: show unexistent tests on issue incidents

There can be incidents relating an issue with a nonexisting test. Since this is part of the issue incidents, it should be shown so that the incident generation is fixed.

Author: MarceloRobert

backend/kernelCI_app/queries/issues.py

@@ -66,7 +66,7 @@ def get_issue_tests(*, issue_id: str, version: Optional[int]) -> list[dict]:
 
     query = f"""
         SELECT
-            T.ID,
+            INC.TEST_ID AS ID,
             T.STATUS,
             T.DURATION,
             T.PATH,
@@ -78,14 +78,15 @@ def get_issue_tests(*, issue_id: str, version: Optional[int]) -> list[dict]:
             C.GIT_REPOSITORY_URL
         FROM
             INCIDENTS INC
-            INNER JOIN TESTS T ON (INC.TEST_ID = T.ID)
+            LEFT JOIN TESTS T ON (INC.TEST_ID = T.ID)
             LEFT JOIN BUILDS B ON (T.BUILD_ID = B.ID)
             LEFT JOIN CHECKOUTS C ON (B.CHECKOUT_ID = C.ID)
         WHERE
             (
                 INC.ISSUE_ID = %(issue_id)s
                 AND {version_clause}
             )
+            AND INC.TEST_ID IS NOT NULL
     """
 
     with connection.cursor() as cursor:

backend/kernelCI_app/typeModels/testDetails.py

@@ -4,8 +4,11 @@
 from kernelCI_app.constants.general import DEFAULT_ORIGIN
 from kernelCI_app.constants.localization import DocStrings
 
+from kernelCI_app.typeModels.common import make_default_validator
 from kernelCI_app.typeModels.databases import (
+    NULL_STATUS,
     Origin,
+    StatusValues,
     Test__Id,
     Build__Id,
     Test__Status,
@@ -35,7 +38,10 @@ class TestDetailsResponse(BaseModel):
     field_timestamp: Timestamp = Field(validation_alias="_timestamp")
     id: Test__Id
     build_id: Build__Id
-    status: Test__Status
+    status: Annotated[
+        StatusValues,
+        make_default_validator(NULL_STATUS),
+    ]
     path: Test__Path
     log_excerpt: Test__LogExcerpt
     log_url: Test__LogUrl

backend/kernelCI_app/views/issueDetailsTestsView.py

@@ -39,7 +39,7 @@ def get(self, _request: HttpRequest, issue_id: Optional[str]) -> Response:
             issue_id=path_params.issue_id, version=query_params.version
         )
 
-        if not tests_data:
+        if not tests_data or len(tests_data) == 1 and tests_data[0].get("id") is None:
             return create_api_error_response(
                 error_message=ClientStrings.ISSUE_TESTS_NOT_FOUND,
                 status_code=HTTPStatus.OK,

dashboard/src/components/BootsTable/BootsTable.tsx

@@ -52,6 +52,7 @@ import { TableHeader } from '@/components/Table/TableHeader';
 
 import { TooltipDateTime } from '@/components/TooltipDateTime';
 import TooltipHardware from '@/components/Table/TooltipHardware';
+import { EMPTY_VALUE } from '@/lib/string';
 
 const defaultColumns: ColumnDef<TestByCommitHash>[] = [
   {
@@ -141,6 +142,10 @@ export function BootsTable({
     (): TTestByCommitHashResponse => ({
       tests: testHistory
         ? testHistory.map((e): TestByCommitHash => {
+            if (!e.path) {
+              e.path = EMPTY_VALUE;
+            }
+
             return {
               duration: e.duration?.toString() ?? '',
               id: e.id,

dashboard/src/components/TestsTable/TestsTable.tsx

@@ -41,6 +41,8 @@ import { usePaginationState } from '@/hooks/usePaginationState';
 import type { TableKeys } from '@/utils/constants/tables';
 import { buildHardwareArray, buildTreeBranch } from '@/utils/table';
 
+import { EMPTY_VALUE } from '@/lib/string';
+
 import { IndividualTestsTable } from './IndividualTestsTable';
 import { defaultColumns, defaultInnerColumns } from './DefaultTestsColumns';
 
@@ -120,6 +122,9 @@ export function TestsTable({
     const groups: Groups = {};
     if (testHistory !== undefined) {
       testHistory.forEach(e => {
+        if (!e.path) {
+          e.path = EMPTY_VALUE;
+        }
         const parts = e.path.split('.', 1);
         const group = parts.length > 0 ? parts[0] : '-';
         if (!(group in groups)) {
@@ -184,7 +189,7 @@ export function TestsTable({
       const individualTest = test.individual_tests.filter(t => {
         let dataIncludesPath = true;
         if (isValidPath) {
-          dataIncludesPath = t.path.includes(path);
+          dataIncludesPath = t.path?.includes(path) ?? false;
         }
         if (dataIncludesPath) {
           countStatus(localGroup, t.status);

dashboard/src/types/general.ts

@@ -21,10 +21,10 @@ export type TPathTests = {
 
 export type TIndividualTest = {
   id: string;
-  path: string;
+  path?: string;
   status?: Status;
-  start_time: string;
-  duration: string;
+  start_time?: string;
+  duration?: string;
   hardware?: string[];
   treeBranch?: string;
 };
@@ -39,9 +39,9 @@ export type TreeBranchItem = {
 };
 
 export type TestHistory = TreeBranchItem & {
-  start_time: string;
+  start_time?: string;
   status: Status;
-  path: string;
+  path?: string;
   id: string;
   duration?: number;
   environment_compatible?: string[];

dashboard/src/types/tree/TreeDetails.tsx

@@ -167,7 +167,7 @@ export type TestByCommitHash = {
   path: string | null;
   status: Status;
   duration: string;
-  startTime: string;
+  startTime?: string;
   hardware?: string[];
   treeBranch?: string;
 };