update golangci-lint to v2.4.0

Signed-off-by: dongjiang <[email protected]>

Author: dongjiang1989

.github/workflows/golangci-lint.yml

@@ -34,6 +34,6 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # tag=v8.0.0
         with:
-          version: v2.3.0
+          version: v2.4.0
           args: --output.text.print-linter-name=true --output.text.colors=true --timeout 10m
           working-directory: ${{matrix.working-directory}}

.golangci.yml

@@ -22,6 +22,7 @@ linters:
     - goconst
     - gocritic
     - gocyclo
+    - godox
     - goprintffuncname
     - govet
     - importas
@@ -51,6 +52,14 @@ linters:
         - fieldalignment
         - shadow
       enable-all: true
+    godox:
+      keywords:
+        - TODO
+        - BUG
+        - FIXME
+        - NOTE
+        - OPTIMIZE
+        - HACK
     importas:
       alias:
         - pkg: k8s.io/api/core/v1
@@ -180,6 +189,9 @@ linters:
           - staticcheck
         path: (.+)\.go$
         text: (ST1000|QF1008)
+      - text: "Line contains TODO/BUG/FIXME"
+        linters:
+          - godox
 issues:
   max-issues-per-linter: 0
   max-same-issues: 0

pkg/cache/cache_test.go

@@ -2568,7 +2568,6 @@ func ensureNode(ctx context.Context, name string, client client.Client) error {
 	return err
 }
 
-//nolint:interfacer
 func isKubeService(svc metav1.Object) bool {
 	// grumble grumble linters grumble grumble
 	return svc.GetNamespace() == "default" && svc.GetName() == "kubernetes"