Skip to content

Commit 7ee45cf

Browse files
authored
Merge pull request #3988 from BenTheElder/log-fixup
remove redundant var log dump from docker provider
2 parents b12cafe + aba08f4 commit 7ee45cf

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

pkg/cluster/internal/providers/docker/provider.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import (
3030
"sigs.k8s.io/kind/pkg/exec"
3131
"sigs.k8s.io/kind/pkg/log"
3232

33-
internallogs "sigs.k8s.io/kind/pkg/cluster/internal/logs"
3433
"sigs.k8s.io/kind/pkg/cluster/internal/providers"
3534
"sigs.k8s.io/kind/pkg/cluster/internal/providers/common"
3635
"sigs.k8s.io/kind/pkg/cluster/nodeutils"
@@ -259,9 +258,6 @@ func (p *provider) CollectLogs(dir string, nodes []nodes.Node) error {
259258
node := n // https://golang.org/doc/faq#closures_and_goroutines
260259
name := node.String()
261260
path := filepath.Join(dir, name)
262-
fns = append(fns, func() error {
263-
return internallogs.DumpDir(p.logger, node, "/var/log", path)
264-
})
265261
fns = append(fns,
266262
execToPathFn(exec.Command("docker", "inspect", name), filepath.Join(path, "inspect.json")),
267263
)

0 commit comments

Comments
 (0)