Skip to content

Commit 2bace00

Browse files
authored
util/set: migrate test-infra to testify (pingcap#26488)
1 parent 65400b6 commit 2bace00

File tree

4 files changed

+68
-43
lines changed

4 files changed

+68
-43
lines changed

util/set/float64_set_test.go

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,13 @@ package set
1616
import (
1717
"testing"
1818

19-
"github.com/pingcap/check"
19+
"github.com/stretchr/testify/assert"
2020
)
2121

22-
func TestT(t *testing.T) {
23-
check.TestingT(t)
24-
}
25-
26-
var _ = check.Suite(&float64SetTestSuite{})
27-
28-
type float64SetTestSuite struct{}
22+
func TestFloat64Set(t *testing.T) {
23+
t.Parallel()
24+
assert := assert.New(t)
2925

30-
func (s *float64SetTestSuite) TestFloat64Set(c *check.C) {
3126
set := NewFloat64Set()
3227
vals := []float64{1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 1.7, 1.8, 1.9, 2.0}
3328
for i := range vals {
@@ -37,12 +32,12 @@ func (s *float64SetTestSuite) TestFloat64Set(c *check.C) {
3732
set.Insert(vals[i])
3833
set.Insert(vals[i])
3934
}
40-
c.Assert(set.Count(), check.Equals, len(vals))
35+
assert.Equal(len(vals), set.Count())
4136

42-
c.Assert(len(set), check.Equals, len(vals))
37+
assert.Equal(len(vals), len(set))
4338
for i := range vals {
44-
c.Assert(set.Exist(vals[i]), check.IsTrue)
39+
assert.True(set.Exist(vals[i]))
4540
}
4641

47-
c.Assert(set.Exist(3), check.IsFalse)
42+
assert.False(set.Exist(3))
4843
}

util/set/int_set_test.go

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,15 @@
1414
package set
1515

1616
import (
17-
"github.com/pingcap/check"
18-
)
17+
"testing"
1918

20-
var _ = check.Suite(&intSetTestSuite{})
19+
"github.com/stretchr/testify/assert"
20+
)
2121

22-
type intSetTestSuite struct{}
22+
func TestIntSet(t *testing.T) {
23+
t.Parallel()
24+
assert := assert.New(t)
2325

24-
func (s *intSetTestSuite) TestIntSet(c *check.C) {
2526
set := NewIntSet()
2627
vals := []int{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}
2728
for i := range vals {
@@ -31,17 +32,20 @@ func (s *intSetTestSuite) TestIntSet(c *check.C) {
3132
set.Insert(vals[i])
3233
set.Insert(vals[i])
3334
}
34-
c.Assert(set.Count(), check.Equals, len(vals))
35+
assert.Equal(len(vals), set.Count())
3536

36-
c.Assert(len(set), check.Equals, len(vals))
37+
assert.Equal(len(vals), len(set))
3738
for i := range vals {
38-
c.Assert(set.Exist(vals[i]), check.IsTrue)
39+
assert.True(set.Exist(vals[i]))
3940
}
4041

41-
c.Assert(set.Exist(11), check.IsFalse)
42+
assert.False(set.Exist(11))
4243
}
4344

44-
func (s *intSetTestSuite) TestInt64Set(c *check.C) {
45+
func TestInt64Set(t *testing.T) {
46+
t.Parallel()
47+
assert := assert.New(t)
48+
4549
set := NewInt64Set()
4650
vals := []int64{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}
4751
for i := range vals {
@@ -52,16 +56,16 @@ func (s *intSetTestSuite) TestInt64Set(c *check.C) {
5256
set.Insert(vals[i])
5357
}
5458

55-
c.Assert(len(set), check.Equals, len(vals))
59+
assert.Equal(len(vals), len(set))
5660
for i := range vals {
57-
c.Assert(set.Exist(vals[i]), check.IsTrue)
61+
assert.True(set.Exist(vals[i]))
5862
}
5963

60-
c.Assert(set.Exist(11), check.IsFalse)
64+
assert.False(set.Exist(11))
6165

6266
set = NewInt64Set(1, 2, 3, 4, 5, 6)
6367
for i := 1; i < 7; i++ {
64-
c.Assert(set.Exist(int64(i)), check.IsTrue)
68+
assert.True(set.Exist(int64(i)))
6569
}
66-
c.Assert(set.Exist(7), check.IsFalse)
70+
assert.False(set.Exist(7))
6771
}

util/set/main_test.go

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
// Copyright 2021 PingCAP, Inc.
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS,
11+
// See the License for the specific language governing permissions and
12+
// limitations under the License.
13+
14+
package set
15+
16+
import (
17+
"testing"
18+
19+
"github.com/pingcap/tidb/util/testbridge"
20+
"go.uber.org/goleak"
21+
)
22+
23+
func TestMain(m *testing.M) {
24+
testbridge.WorkaroundGoCheckFlags()
25+
goleak.VerifyTestMain(m)
26+
}

util/set/string_set_test.go

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ package set
1515

1616
import (
1717
"fmt"
18+
"testing"
1819

19-
"github.com/pingcap/check"
20+
"github.com/stretchr/testify/assert"
2021
)
2122

22-
var _ = check.Suite(&stringSetTestSuite{})
23+
func TestStringSet(t *testing.T) {
24+
t.Parallel()
25+
assert := assert.New(t)
2326

24-
type stringSetTestSuite struct{}
25-
26-
func (s *stringSetTestSuite) TestStringSet(c *check.C) {
2727
set := NewStringSet()
2828
vals := []string{"1", "2", "3", "4", "5", "6", "7", "8", "9", "10"}
2929
for i := range vals {
@@ -33,32 +33,32 @@ func (s *stringSetTestSuite) TestStringSet(c *check.C) {
3333
set.Insert(vals[i])
3434
set.Insert(vals[i])
3535
}
36-
c.Assert(set.Count(), check.Equals, len(vals))
36+
assert.Equal(len(vals), set.Count())
3737

38-
c.Assert(len(set), check.Equals, len(vals))
38+
assert.Equal(len(vals), len(set))
3939
for i := range vals {
40-
c.Assert(set.Exist(vals[i]), check.IsTrue)
40+
assert.True(set.Exist(vals[i]))
4141
}
4242

43-
c.Assert(set.Exist("11"), check.IsFalse)
43+
assert.False(set.Exist("11"))
4444

4545
set = NewStringSet("1", "2", "3", "4", "5", "6")
4646
for i := 1; i < 7; i++ {
47-
c.Assert(set.Exist(fmt.Sprintf("%d", i)), check.IsTrue)
47+
assert.True(set.Exist(fmt.Sprintf("%d", i)))
4848
}
49-
c.Assert(set.Exist("7"), check.IsFalse)
49+
assert.False(set.Exist("7"))
5050

5151
s1 := NewStringSet("1", "2", "3")
5252
s2 := NewStringSet("4", "2", "3")
5353
s3 := s1.Intersection(s2)
54-
c.Assert(s3, check.DeepEquals, NewStringSet("2", "3"))
54+
assert.Equal(NewStringSet("2", "3"), s3)
5555

5656
s4 := NewStringSet("4", "5", "3")
57-
c.Assert(s3.Intersection(s4), check.DeepEquals, NewStringSet("3"))
57+
assert.Equal(NewStringSet("3"), s3.Intersection(s4))
5858

5959
s5 := NewStringSet("4", "5")
60-
c.Assert(s3.Intersection(s5), check.DeepEquals, NewStringSet())
60+
assert.Equal(NewStringSet(), s3.Intersection(s5))
6161

6262
s6 := NewStringSet()
63-
c.Assert(s3.Intersection(s6), check.DeepEquals, NewStringSet())
63+
assert.Equal(NewStringSet(), s3.Intersection(s6))
6464
}

0 commit comments

Comments
 (0)