Skip to content

Commit a4f2591

Browse files
committed
Add AttrSIPTrunkHostName for SIP trunk host identification
1 parent 48ed047 commit a4f2591

File tree

5 files changed

+12
-7
lines changed

5 files changed

+12
-7
lines changed

livekit/attrs.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ const (
1212
AttrSIPDispatchRuleID = AttrSIPPrefix + "ruleID"
1313
// AttrSIPTrunkNumber attribute contains number associate with LiveKit SIP Trunk.
1414
// This attribute will be omitted if HidePhoneNumber is set.
15-
AttrSIPTrunkNumber = AttrSIPPrefix + "trunkPhoneNumber"
15+
AttrSIPTrunkNumber = AttrSIPPrefix + "trunkPhoneNumber"
16+
AttrSIPTrunkHostName = AttrSIPPrefix + "trunkHostName"
1617
// AttrSIPPhoneNumber attribute contains number external to LiveKit SIP (caller for inbound and called number for outbound).
1718
// This attribute will be omitted if HidePhoneNumber is set.
1819
AttrSIPPhoneNumber = AttrSIPPrefix + "phoneNumber"

rpc/sip.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ func NewCreateSIPParticipantRequest(
133133
attrs[livekit.AttrSIPPhoneNumber] = req.SipCallTo
134134
attrs[livekit.AttrSIPHostName] = hostname
135135
attrs[livekit.AttrSIPTrunkNumber] = outboundNumber
136+
attrs[livekit.AttrSIPTrunkHostName] = ownHostname
136137
}
137138

138139
var features []livekit.SIPFeature

rpc/sip_test.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,13 @@ func TestNewCreateSIPParticipantRequest(t *testing.T) {
5757
Dtmf: "1234#",
5858
PlayDialtone: true,
5959
ParticipantAttributes: map[string]string{
60-
"extra": "1",
61-
livekit.AttrSIPCallID: "call-id",
62-
livekit.AttrSIPTrunkID: "trunk",
63-
livekit.AttrSIPTrunkNumber: "+1111",
64-
livekit.AttrSIPPhoneNumber: "+3333",
65-
livekit.AttrSIPHostName: "sip.example.com",
60+
"extra": "1",
61+
livekit.AttrSIPCallID: "call-id",
62+
livekit.AttrSIPTrunkID: "trunk",
63+
livekit.AttrSIPTrunkNumber: "+1111",
64+
livekit.AttrSIPTrunkHostName: "sip2.example.com",
65+
livekit.AttrSIPPhoneNumber: "+3333",
66+
livekit.AttrSIPHostName: "sip.example.com",
6667
},
6768
Headers: map[string]string{
6869
"X-A": "A",

sip/sip.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -831,6 +831,7 @@ func EvaluateDispatchRule(projectID string, trunk *livekit.SIPInboundTrunkInfo,
831831
attrs[livekit.AttrSIPPhoneNumber] = call.From.User
832832
attrs[livekit.AttrSIPHostName] = call.From.Host
833833
attrs[livekit.AttrSIPTrunkNumber] = call.To.User
834+
attrs[livekit.AttrSIPTrunkHostName] = call.To.Host
834835
}
835836

836837
room, rulePin, err := GetPinAndRoom(rule)

sip/sip_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -673,6 +673,7 @@ func TestEvaluateDispatchRule(t *testing.T) {
673673
livekit.AttrSIPDispatchRuleID: "rule",
674674
livekit.AttrSIPPhoneNumber: "+11112222",
675675
livekit.AttrSIPTrunkNumber: "+3333",
676+
livekit.AttrSIPTrunkHostName: "sip2.example.com",
676677
livekit.AttrSIPHostName: "sip.example.com",
677678
},
678679
}, res)

0 commit comments

Comments
 (0)