Skip to content

Conversation

willdurand
Copy link
Member

@willdurand willdurand commented May 23, 2022

Depends on #2400


We'll need [email protected] or above but this is something we probably want as privileged extension developers might use web-ext lint.

@willdurand willdurand marked this pull request as draft May 23, 2022 09:30
@willdurand willdurand marked this pull request as ready for review May 23, 2022 12:45
@willdurand willdurand requested a review from rpl May 23, 2022 12:45
@willdurand willdurand changed the title Add --privileged CLI flag to the lint command feat: add --privileged CLI flag to the lint command May 23, 2022
Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, the CI job failure is just because of the commit message not following the conventions enforced by commitlint, I'll fix the commit message as part of the squash and merge.

@willdurand
Copy link
Member Author

Thanks!

(fixing the PR title should already fix the commit message when using squash and merge)

@rpl rpl merged commit 50d023c into master May 23, 2022
@rpl rpl deleted the privileged branch May 23, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants