Skip to content

BUG: Neptune Captures Non-Standard Git Patch Format When Using External Diff Viewer #1887

@liblaf

Description

@liblaf

Thank you for creating neptune.ai, the best tool for experiment tracking!

I have configured an external diff viewer, difftastic, in my Git configuration. However, I noticed that neptune captures the diff in a non-standard Git patch format, which appears to be the output format of my custom diff viewer.

Here is a snippet from my ~/.gitconfig:

[diff]
external = difft
tool = difftastic

[difftool]
prompt = false

[difftool "difftastic"]
cmd = difftastic "$LOCAL" "$REMOTE"

An example of a tracked experiment run can be found here: Neptune Experiment Run.

I believe that Neptune should avoid using the external diff viewer to ensure that the captured patch is in the standard Git patch format. The --no-ext-diff option in git diff might be useful for this purpose. Here is the relevant documentation: Git Diff Documentation.

Suggested Solution:

Consider adding an option or configuration setting in neptune to disable the use of external diff viewers when capturing patches. This would ensure that the captured diff is always in the standard Git patch format, regardless of the user's Git configuration.

Steps to Reproduce:

  1. Configure an external diff viewer in your Git configuration (e.g., difftastic).
  2. Run an experiment and capture the source code diff.
  3. Observe that the captured diff is in the format of the external diff viewer, not the standard Git patch format.

Expected Behavior:

Neptune should capture the diff in the standard Git patch format, even if an external diff viewer is configured in Git.

Actual Behavior:

Neptune captures the diff in the format of the external diff viewer, which is not the standard Git patch format.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions