Skip to content

Conversation

erka
Copy link
Contributor

@erka erka commented Jun 3, 2025

This PR

  • bump open-feature/go-sdk to v1.15.0 for OpenFeature in-house providers and hooks

Related Issues

closes #672
related #644

Notes

There are a few corrections where providers use an incorrect approach to initialize their providers.

Follow-up Tasks

The hooks interface has changed — there may be additional methods that need to be implemented.

Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
@erka erka changed the title chore: bump open-feature/go-sdk from v1.11 to v1.15 chore!: bump open-feature/go-sdk from v1.11 to v1.15 Jun 3, 2025
@erka erka marked this pull request as ready for review June 3, 2025 17:21
@erka erka requested review from a team as code owners June 3, 2025 17:21
@erka erka changed the title chore!: bump open-feature/go-sdk from v1.11 to v1.15 fix(deps)!: bump open-feature/go-sdk from v1.11 to v1.15 Jun 3, 2025
@sahidvelji
Copy link
Contributor

Interesting that the lint check passed even though there are linter findings. But that's a separate issue. The changes look good to me!

@erka
Copy link
Contributor Author

erka commented Jun 4, 2025

@sahidvelji We should also consider bumping the linter to v2 in go-sdk-contrib for consistency with go-sdk.

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks @erka! It's worth noting that this PR is marked as a breaking change. This will cause all artifacts that are 1.0 or higher to release a new major version. That may be okay, but I figured I would mention that.

By the way, does anyone have experience releasing a new major version artifact? It has been a while since I looked into it but I remember being surprised how complex it was at the time.

@toddbaert
Copy link
Member

toddbaert commented Jun 10, 2025

Wow, thanks @erka! It's worth noting that this PR is marked as a breaking change. This will cause all artifacts that are 1.0 or higher to release a new major version. That may be okay, but I figured I would mention that.

By the way, does anyone have experience releasing a new major version artifact? It has been a while since I looked into it but I remember being surprised how complex it was at the time.

I'd recommend we don't make this a breaking change. Based on the idioms and expectations of the Go ecosystem, I don't think this is necessary (as long as the only requirement in adoption will be updating dep/runtime versions).

@erka
Copy link
Contributor Author

erka commented Jun 10, 2025

@beeme1mr @toddbaert You’re right — there is no breaking change in this PR. I believe the actual sort of breaking change occurred in the go-sdk itself, and SetProviderAndWait should be used in most cases. Someone told about this in another issue or Slack channel. I expect someone will face the same issue where they used SetProvider and now they will have to switch to SetProviderAndWait. I'm not sure if I should update the examples here as well, or if that should be handled separately.

I need to tidy up this PR a bit and remove the toolchain directive from the modified go.mod files before merging.

@erka erka changed the title fix(deps)!: bump open-feature/go-sdk from v1.11 to v1.15 fix(deps): bump open-feature/go-sdk from v1.11 to v1.15 Jun 10, 2025
@beeme1mr beeme1mr merged commit ce87102 into open-feature:main Jun 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump OpenFeature SDK version to latest