-
Notifications
You must be signed in to change notification settings - Fork 63
fix(deps): bump open-feature/go-sdk from v1.11 to v1.15 #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
Interesting that the lint check passed even though there are linter findings. But that's a separate issue. The changes look good to me! |
@sahidvelji We should also consider bumping the linter to v2 in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thanks @erka! It's worth noting that this PR is marked as a breaking change. This will cause all artifacts that are 1.0 or higher to release a new major version. That may be okay, but I figured I would mention that.
By the way, does anyone have experience releasing a new major version artifact? It has been a while since I looked into it but I remember being surprised how complex it was at the time.
I'd recommend we don't make this a breaking change. Based on the idioms and expectations of the Go ecosystem, I don't think this is necessary (as long as the only requirement in adoption will be updating dep/runtime versions). |
@beeme1mr @toddbaert You’re right — there is no breaking change in this PR. I believe the actual sort of breaking change occurred in the go-sdk itself, and I need to tidy up this PR a bit and remove the |
Signed-off-by: Roman Dmytrenko <[email protected]>
This PR
Related Issues
closes #672
related #644
Notes
There are a few corrections where providers use an incorrect approach to initialize their providers.
Follow-up Tasks
The hooks interface has changed — there may be additional methods that need to be implemented.