- OCResourceManager: fix accidental increase of cache size to unlimited - and instead implement what was intended: prevent caching altogether

felix-schwarz · felix-schwarz · commit 7bfe325eee04 · 2025-01-22T10:47:45.000+01:00
diff --git a/ownCloudSDK/Core/Resources/Manager/OCResourceManager.m b/ownCloudSDK/Core/Resources/Manager/OCResourceManager.m
@@ -63,11 +63,14 @@ - (void)setMemoryConfiguration:(OCPlatformMemoryConfiguration)memoryConfiguratio
 	switch (_memoryConfiguration)
 	{
 		case OCPlatformMemoryConfigurationDefault:
+			if (_cache == nil) {
+				_cache = [OCCache new];
+			}
 			_cache.countLimit = OCCacheLimitNone;
 		break;
 
 		case OCPlatformMemoryConfigurationMinimum:
-			_cache.countLimit = 0;
+			_cache = nil; // Do not perform any caching
 		break;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -63,11 +63,14 @@ - (void)setMemoryConfiguration:(OCPlatformMemoryConfiguration)memoryConfiguratio`
`63`	`63`	`switch (_memoryConfiguration)`
`64`	`64`	`{`
`65`	`65`	`case OCPlatformMemoryConfigurationDefault:`
	`66`	`+ if (_cache == nil) {`
	`67`	`+ _cache = [OCCache new];`
	`68`	`+ }`
`66`	`69`	`_cache.countLimit = OCCacheLimitNone;`
`67`	`70`	`break;`
`68`	`71`
`69`	`72`	`case OCPlatformMemoryConfigurationMinimum:`
`70`		`- _cache.countLimit = 0;`
	`73`	`+ _cache = nil; // Do not perform any caching`
`71`	`74`	`break;`
`72`	`75`	`}`
`73`	`76`	`}`