Skip to content

Commit 6818009

Browse files
authored
logpuller: remove unnecessary log (#1925)
close #1397
1 parent 042119f commit 6818009

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

logservice/logpuller/region_event_handler.go

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -128,20 +128,21 @@ func (h *regionEventHandler) GetArea(path SubscriptionID, dest *subscribedSpan)
128128
}
129129

130130
func (h *regionEventHandler) GetTimestamp(event regionEvent) dynstream.Timestamp {
131-
if event.entries != nil && event.entries.Entries != nil && len(event.entries.Entries.GetEntries()) > 0 {
132-
entries := event.entries.Entries.GetEntries()
133-
switch entries[0].Type {
134-
case cdcpb.Event_INITIALIZED:
135-
return dynstream.Timestamp(event.state.region.resolvedTs())
136-
case cdcpb.Event_COMMITTED,
137-
cdcpb.Event_PREWRITE,
138-
cdcpb.Event_COMMIT,
139-
cdcpb.Event_ROLLBACK:
140-
return dynstream.Timestamp(entries[0].CommitTs)
141-
default:
142-
log.Warn("unknown event entries", zap.Any("event", event.entries))
143-
return 0
131+
if event.entries != nil && event.entries.Entries != nil {
132+
for _, entry := range event.entries.Entries.GetEntries() {
133+
switch entry.Type {
134+
case cdcpb.Event_INITIALIZED:
135+
return dynstream.Timestamp(event.state.region.resolvedTs())
136+
case cdcpb.Event_COMMITTED,
137+
cdcpb.Event_PREWRITE,
138+
cdcpb.Event_COMMIT,
139+
cdcpb.Event_ROLLBACK:
140+
return dynstream.Timestamp(entry.CommitTs)
141+
default:
142+
// ignore other event types
143+
}
144144
}
145+
return 0
145146
} else {
146147
return dynstream.Timestamp(event.resolvedTs)
147148
}

0 commit comments

Comments
 (0)