ddl: enable fast create table on default (#57215) (#57254)

close #57214

Author: ti-chi-bot

br/pkg/restore/snap_client/systable_restore_test.go

@@ -116,5 +116,5 @@ func TestCheckSysTableCompatibility(t *testing.T) {
 //
 // The above variables are in the file br/pkg/restore/systable_restore.go
 func TestMonitorTheSystemTableIncremental(t *testing.T) {
-	require.Equal(t, int64(217), session.CurrentBootstrapVersion)
+	require.Equal(t, int64(218), session.CurrentBootstrapVersion)
 }

pkg/ddl/tests/fastcreatetable/fastcreatetable_test.go

@@ -39,7 +39,7 @@ func TestSwitchFastCreateTable(t *testing.T) {
 	conn := server.CreateMockConn(t, sv)
 	tk := testkit.NewTestKitWithSession(t, store, conn.Context().Session)
 
-	tk.MustQuery("show global variables like 'tidb_enable_fast_create_table'").Check(testkit.Rows("tidb_enable_fast_create_table OFF"))
+	tk.MustQuery("show global variables like 'tidb_enable_fast_create_table'").Check(testkit.Rows("tidb_enable_fast_create_table ON"))
 
 	tk.MustExec("create database db1;")
 	tk.MustExec("create database db2;")

pkg/session/bootstrap.go

@@ -1186,11 +1186,21 @@ const (
 	// version 217
 	// Keep tidb_schema_cache_size to 0 if this variable does not exist (upgrading from old version pre 8.1).
 	version217 = 217
+
+	// version 218
+	// enable fast_create_table on default
+	version218 = 218
+
+	// ...
+	// [version219, version238] is the version range reserved for patches of 8.5.x
+	// ...
+
+	// next version should start with 239
 )
 
 // currentBootstrapVersion is defined as a variable, so we can modify its value for testing.
 // please make sure this is the largest version
-var currentBootstrapVersion int64 = version217
+var currentBootstrapVersion int64 = version218
 
 // DDL owner key's expired time is ManagerSessionTTL seconds, we should wait the time and give more time to have a chance to finish it.
 var internalSQLTimeout = owner.ManagerSessionTTL + 15
@@ -1363,6 +1373,7 @@ var (
 		upgradeToVer215,
 		upgradeToVer216,
 		upgradeToVer217,
+		upgradeToVer218,
 	}
 )
 
@@ -3254,6 +3265,13 @@ func upgradeToVer217(s sessiontypes.Session, ver int64) {
 	mustExecute(s, "INSERT IGNORE INTO mysql.global_variables VALUES ('tidb_schema_cache_size', 0)")
 }
 
+func upgradeToVer218(_ sessiontypes.Session, ver int64) {
+	if ver >= version218 {
+		return
+	}
+	// empty, just make lint happy.
+}
+
 // initGlobalVariableIfNotExists initialize a global variable with specific val if it does not exist.
 func initGlobalVariableIfNotExists(s sessiontypes.Session, name string, val any) {
 	ctx := kv.WithInternalSourceType(context.Background(), kv.InternalTxnBootstrap)

pkg/sessionctx/variable/tidb_vars.go

@@ -1441,7 +1441,7 @@ const (
 	DefTiDBEnablePrepPlanCacheMemoryMonitor           = true
 	DefTiDBPrepPlanCacheMemoryGuardRatio              = 0.1
 	DefTiDBEnableDistTask                             = true
-	DefTiDBEnableFastCreateTable                      = false
+	DefTiDBEnableFastCreateTable                      = true
 	DefTiDBSimplifiedMetrics                          = false
 	DefTiDBEnablePaging                               = true
 	DefTiFlashFineGrainedShuffleStreamCount           = 0