statistics: temporarily skip handling errors for DDL events (#58609)

ref #58545

Author: 0xPoe

pkg/statistics/handle/ddl/BUILD.bazel

@@ -31,7 +31,7 @@ go_test(
     timeout = "short",
     srcs = ["ddl_test.go"],
     flaky = True,
-    shard_count = 20,
+    shard_count = 21,
     deps = [
         ":ddl",
         "//pkg/ddl/notifier",

pkg/statistics/handle/ddl/ddl.go

@@ -21,9 +21,11 @@ import (
 	"github.com/pingcap/tidb/pkg/ddl/notifier"
 	"github.com/pingcap/tidb/pkg/sessionctx"
 	"github.com/pingcap/tidb/pkg/statistics/handle/lockstats"
+	statslogutil "github.com/pingcap/tidb/pkg/statistics/handle/logutil"
 	"github.com/pingcap/tidb/pkg/statistics/handle/storage"
 	"github.com/pingcap/tidb/pkg/statistics/handle/types"
 	"github.com/pingcap/tidb/pkg/statistics/handle/util"
+	"go.uber.org/zap"
 )
 
 type ddlHandlerImpl struct {
@@ -48,7 +50,16 @@ func NewDDLHandler(
 
 // HandleDDLEvent begins to process a ddl task.
 func (h *ddlHandlerImpl) HandleDDLEvent(ctx context.Context, sctx sessionctx.Context, s *notifier.SchemaChangeEvent) error {
-	return h.sub.handle(ctx, sctx, s)
+	// Ideally, we shouldn't allow any errors to be ignored, but for now, some queries can fail.
+	// Temporarily ignore the error and we need to check all queries to ensure they are correct.
+	if err := h.sub.handle(ctx, sctx, s); err != nil {
+		statslogutil.StatsLogger().Warn(
+			"failed to handle DDL event",
+			zap.String("event", s.String()),
+			zap.Error(err),
+		)
+	}
+	return nil
 }
 
 // DDLEventCh returns ddl events channel in handle.

pkg/statistics/handle/ddl/ddl_test.go

@@ -1380,3 +1380,18 @@ func TestExchangePartition(t *testing.T) {
 	require.Equal(t, int64(200), count)
 	require.Equal(t, int64(200), modifyCount)
 }
+
+func TestDumpStatsDeltaBeforeHandleDDLEvent(t *testing.T) {
+	store, dom := testkit.CreateMockStoreAndDomain(t)
+	tk := testkit.NewTestKit(t, store)
+	tk.MustExec("use test")
+	tk.MustExec("create table t (c1 int)")
+	// Insert some data.
+	tk.MustExec("insert into t values (1), (2), (3)")
+	h := dom.StatsHandle()
+	require.NoError(t, h.DumpStatsDeltaToKV(true))
+	// Find the DDL event.
+	event := findEvent(h.DDLEventCh(), model.ActionCreateTable)
+	err := statstestutil.HandleDDLEventWithTxn(h, event)
+	require.NoError(t, err)
+}