Skip to content

Commit 14a1cb0

Browse files
authored
executor: do not track membuffer's memory in executor (#53985) (#55627)
close #53984
1 parent a1c8a89 commit 14a1cb0

File tree

3 files changed

+0
-12
lines changed

3 files changed

+0
-12
lines changed

executor/delete.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -148,11 +148,6 @@ func (e *DeleteExec) deleteSingleTableByChunk(ctx context.Context) error {
148148
}
149149

150150
func (e *DeleteExec) doBatchDelete(ctx context.Context) error {
151-
txn, err := e.ctx.Txn(false)
152-
if err != nil {
153-
return ErrBatchInsertFail.GenWithStack("BatchDelete failed with error: %v", err)
154-
}
155-
e.memTracker.Consume(-int64(txn.Size()))
156151
e.ctx.StmtCommit()
157152
if err := sessiontxn.NewTxnInStmt(ctx, e.ctx); err != nil {
158153
// We should return a special error for batch insert.

executor/insert_common.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -532,11 +532,6 @@ func insertRowsFromSelect(ctx context.Context, base insertCommon) error {
532532
}
533533

534534
func (e *InsertValues) doBatchInsert(ctx context.Context) error {
535-
txn, err := e.ctx.Txn(false)
536-
if err != nil {
537-
return ErrBatchInsertFail.GenWithStack("BatchInsert failed with error: %v", err)
538-
}
539-
e.memTracker.Consume(-int64(txn.Size()))
540535
e.ctx.StmtCommit()
541536
if err := sessiontxn.NewTxnInStmt(ctx, e.ctx); err != nil {
542537
// We should return a special error for batch insert.

executor/replace.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@ func (e *ReplaceExec) exec(ctx context.Context, newRows [][]types.Datum) error {
160160
if err != nil {
161161
return err
162162
}
163-
txnSize := txn.Size()
164163

165164
if e.collectRuntimeStatsEnabled() {
166165
if snapshot := txn.GetSnapshot(); snapshot != nil {
@@ -186,7 +185,6 @@ func (e *ReplaceExec) exec(ctx context.Context, newRows [][]types.Datum) error {
186185
return err
187186
}
188187
}
189-
e.memTracker.Consume(int64(txn.Size() - txnSize))
190188
return nil
191189
}
192190

0 commit comments

Comments
 (0)