importinto/lightning: fix incorrect datatime value for zero date (#51201)

close #50757

Author: GMHDBJD

br/pkg/lightning/backend/kv/session.go

@@ -292,7 +292,8 @@ func NewSession(options *encode.SessionOptions, logger log.Logger) *Session {
 	typeFlags := vars.StmtCtx.TypeFlags().
 		WithTruncateAsWarning(!sqlMode.HasStrictMode()).
 		WithIgnoreInvalidDateErr(sqlMode.HasAllowInvalidDatesMode()).
-		WithIgnoreZeroInDate(!sqlMode.HasStrictMode() || sqlMode.HasAllowInvalidDatesMode())
+		WithIgnoreZeroInDate(!sqlMode.HasStrictMode() || sqlMode.HasAllowInvalidDatesMode() ||
+			!sqlMode.HasNoZeroInDateMode() || !sqlMode.HasNoZeroDateMode())
 	vars.StmtCtx.SetTypeFlags(typeFlags)
 
 	errLevels := vars.StmtCtx.ErrLevels()

tests/realtikvtest/importintotest/import_into_test.go

@@ -1166,3 +1166,26 @@ func (s *mockGCSSuite) TestAnalyze() {
 	}, 60*time.Second, time.Second)
 	s.tk.MustQuery("SHOW ANALYZE STATUS;").CheckContain("analyze_table")
 }
+
+func (s *mockGCSSuite) TestZeroDateTime() {
+	s.tk.MustExec("DROP DATABASE IF EXISTS import_into;")
+	s.tk.MustExec("CREATE DATABASE import_into;")
+
+	s.tk.MustExec("create table import_into.zero_time_table(t datetime)")
+	s.tk.MustExec("set @@sql_mode='STRICT_TRANS_TABLES'")
+
+	s.server.CreateObject(fakestorage.Object{
+		ObjectAttrs: fakestorage.ObjectAttrs{BucketName: "test-load", Name: "zero_time.csv"},
+		Content:     []byte("1990-01-00 00:00:00\n"),
+	})
+
+	sql := fmt.Sprintf(`IMPORT INTO import_into.zero_time_table FROM 'gs://test-load/zero_time.csv?endpoint=%s'`, gcsEndpoint)
+	s.tk.MustQuery(sql)
+	s.tk.MustQuery("SELECT * FROM import_into.zero_time_table;").Sort().Check(testkit.Rows("1990-01-00 00:00:00"))
+
+	// set default value
+	s.tk.MustExec("set @@sql_mode='ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'")
+	s.tk.MustExec("truncate table import_into.zero_time_table")
+	err := s.tk.QueryToErr(sql)
+	s.ErrorContains(err, `Incorrect datetime value: '1990-01-00 00:00:00'`)
+}