Skip to content

Commit 5b19ce2

Browse files
committed
resolve conflicts
1 parent 58fd04a commit 5b19ce2

File tree

7 files changed

+6
-853
lines changed

7 files changed

+6
-853
lines changed

pkg/planner/core/exhaust_physical_plans.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1125,16 +1125,9 @@ func (*LogicalJoin) constructInnerProj(proj *LogicalProjection, child PhysicalPl
11251125
return child
11261126
}
11271127
physicalProj := PhysicalProjection{
1128-
<<<<<<< HEAD
1129-
Exprs: proj.Exprs,
1130-
CalculateNoDelay: proj.CalculateNoDelay,
1131-
AvoidColumnEvaluator: proj.AvoidColumnEvaluator,
1132-
}.Init(proj.SCtx(), proj.StatsInfo(), proj.QueryBlockOffset(), nil)
1133-
=======
11341128
Exprs: proj.Exprs,
11351129
CalculateNoDelay: proj.CalculateNoDelay,
1136-
}.Init(proj.SCtx(), proj.StatsInfo(), proj.QueryBlockOffset(), prop)
1137-
>>>>>>> 004b442fb9a (pkg/planner: set proj.AvoidColumnEvaluator in postOptimize (#55333))
1130+
}.Init(proj.SCtx(), proj.StatsInfo(), proj.QueryBlockOffset(), nil)
11381131
physicalProj.SetChildren(child)
11391132
physicalProj.SetSchema(proj.schema)
11401133
return physicalProj

pkg/planner/core/logical_plan_builder.go

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1987,13 +1987,8 @@ func (b *PlanBuilder) buildProjection4Union(_ context.Context, u *LogicalUnionAl
19871987
}
19881988
}
19891989
b.optFlag |= flagEliminateProjection
1990-
<<<<<<< HEAD
1991-
proj := LogicalProjection{Exprs: exprs, AvoidColumnEvaluator: true}.Init(b.ctx, b.getSelectOffset())
1990+
proj := LogicalProjection{Exprs: exprs}.Init(b.ctx, b.getSelectOffset())
19921991
proj.SetSchema(u.schema.Clone())
1993-
=======
1994-
proj := logicalop.LogicalProjection{Exprs: exprs}.Init(b.ctx, b.getSelectOffset())
1995-
proj.SetSchema(u.Schema().Clone())
1996-
>>>>>>> 004b442fb9a (pkg/planner: set proj.AvoidColumnEvaluator in postOptimize (#55333))
19971992
// reset the schema type to make the "not null" flag right.
19981993
for i, expr := range exprs {
19991994
proj.schema.Columns[i].RetType = expr.GetType()
@@ -7690,11 +7685,7 @@ func (b *PlanBuilder) buildProjection4CTEUnion(_ context.Context, seed LogicalPl
76907685
}
76917686
}
76927687
b.optFlag |= flagEliminateProjection
7693-
<<<<<<< HEAD
7694-
proj := LogicalProjection{Exprs: exprs, AvoidColumnEvaluator: true}.Init(b.ctx, b.getSelectOffset())
7695-
=======
7696-
proj := logicalop.LogicalProjection{Exprs: exprs}.Init(b.ctx, b.getSelectOffset())
7697-
>>>>>>> 004b442fb9a (pkg/planner: set proj.AvoidColumnEvaluator in postOptimize (#55333))
7688+
proj := LogicalProjection{Exprs: exprs}.Init(b.ctx, b.getSelectOffset())
76987689
proj.SetSchema(resSchema)
76997690
proj.SetChildren(recur)
77007691
return proj, nil

pkg/planner/core/logical_plans.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -800,13 +800,6 @@ type LogicalProjection struct {
800800
// See "https://dev.mysql.com/doc/refman/5.7/en/do.html" for more detail.
801801
CalculateNoDelay bool
802802

803-
// AvoidColumnEvaluator is a temporary variable which is ONLY used to avoid
804-
// building columnEvaluator for the expressions of Projection which is
805-
// built by buildProjection4Union.
806-
// This can be removed after column pool being supported.
807-
// Related issue: TiDB#8141(https://github.com/pingcap/tidb/issues/8141)
808-
AvoidColumnEvaluator bool
809-
810803
// Proj4Expand is used for expand to project same column reference, while these
811804
// col may be filled with null so we couldn't just eliminate this projection itself.
812805
Proj4Expand bool

pkg/planner/core/logical_union_all.go

Lines changed: 0 additions & 195 deletions
This file was deleted.

0 commit comments

Comments
 (0)