br: reduce memory usage when get incomplete ranges (#57192) (#57342)

ti-chi-bot · web-flow · commit 6e6a0128a76a · 2024-11-15T05:13:47.000Z
close #53529
diff --git a/br/pkg/rtree/rtree.go b/br/pkg/rtree/rtree.go
@@ -418,7 +418,8 @@ func (rangeTree *ProgressRangeTree) Iter() *IncompleteRangesFetcher {
 }
 
 func (iter *IncompleteRangesFetcher) GetIncompleteRanges() []Range {
-	incompleteRanges := make([]Range, 0, 64*len(iter.items))
+	// about 64 MB memory if there are 1 million ranges
+	incompleteRanges := make([]Range, 0, len(iter.items))
 	for _, item := range iter.items {
 		if item.complete {
 			continue

Original file line number	Diff line number	Diff line change
`@@ -418,7 +418,8 @@ func (rangeTree ProgressRangeTree) Iter() IncompleteRangesFetcher {`
`418`	`418`	`}`
`419`	`419`
`420`	`420`	`func (iter *IncompleteRangesFetcher) GetIncompleteRanges() []Range {`
`421`		`- incompleteRanges := make([]Range, 0, 64*len(iter.items))`
	`421`	`+ // about 64 MB memory if there are 1 million ranges`
	`422`	`+ incompleteRanges := make([]Range, 0, len(iter.items))`
`422`	`423`	`for _, item := range iter.items {`
`423`	`424`	`if item.complete {`
`424`	`425`	`continue`