Skip to content

Commit 73082a2

Browse files
authored
statistics: add recover to protect background task (#58739) (#58763)
close #58738
1 parent 655a986 commit 73082a2

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

metrics/metrics.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ const (
5454
LabelDDLSyncer = "ddl-syncer"
5555
LabelGCWorker = "gcworker"
5656
LabelAnalyze = "analyze"
57+
LabelStats = "stats"
5758

5859
LabelBatchRecvLoop = "batch-recv-loop"
5960
LabelBatchSendLoop = "batch-send-loop"

statistics/handle/ddl.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"github.com/pingcap/errors"
2121
"github.com/pingcap/tidb/ddl/util"
2222
"github.com/pingcap/tidb/kv"
23+
"github.com/pingcap/tidb/metrics"
2324
"github.com/pingcap/tidb/parser/ast"
2425
"github.com/pingcap/tidb/parser/model"
2526
"github.com/pingcap/tidb/parser/mysql"
@@ -28,13 +29,15 @@ import (
2829
"github.com/pingcap/tidb/sessionctx/variable"
2930
"github.com/pingcap/tidb/sessiontxn"
3031
"github.com/pingcap/tidb/types"
32+
tidbutil "github.com/pingcap/tidb/util"
3133
"github.com/pingcap/tidb/util/logutil"
3234
"github.com/pingcap/tidb/util/sqlexec"
3335
"go.uber.org/zap"
3436
)
3537

3638
// HandleDDLEvent begins to process a ddl task.
3739
func (h *Handle) HandleDDLEvent(t *util.Event) error {
40+
defer tidbutil.Recover(metrics.LabelStats, "handleDDLEvent", nil, false)
3841
switch t.Tp {
3942
case model.ActionCreateTable, model.ActionTruncateTable:
4043
ids := h.getInitStateTableIDs(t.TableInfo)

0 commit comments

Comments
 (0)