Skip to content

Commit 8f454b4

Browse files
committed
rollback toml config changes
Signed-off-by: artem_danilov <[email protected]>
1 parent 620862d commit 8f454b4

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

cmd/tidb-server/main.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ import (
8686
"github.com/prometheus/client_golang/prometheus/push"
8787
"github.com/tikv/client-go/v2/tikv"
8888
"github.com/tikv/client-go/v2/txnkv/transaction"
89-
"github.com/tikv/pd/client/pkg/circuitbreaker"
9089
"go.uber.org/automaxprocs/maxprocs"
9190
"go.uber.org/zap"
9291
)
@@ -804,15 +803,6 @@ func setGlobalVars() {
804803

805804
atomic.StoreUint64(&transaction.CommitMaxBackoff, uint64(parseDuration(cfg.TiKVClient.CommitTimeout).Seconds()*1000))
806805
tikv.SetRegionCacheTTLSec(int64(cfg.TiKVClient.RegionCacheTTL))
807-
tikv.ChangePdRegionMetaCircuitBreakerSettings(func(config *circuitbreaker.Settings) {
808-
s := cfg.TiKVClient.CircuitBreakerSettingsList.PDRegionsMetadata
809-
// config.ErrorRateThreshold is controlled by tidb_cb_pd_metadata_error_rate_threshold_pct sysvar
810-
config.ErrorRateWindow = time.Duration(s.ErrorRateEvaluationWindowSeconds) * time.Second
811-
config.MinQPSForOpen = uint32(s.MinQPSToOpen)
812-
config.CoolDownInterval = time.Duration(s.CooldownIntervalSeconds) * time.Second
813-
config.HalfOpenSuccessCount = uint32(s.HalfOpenSuccessCount)
814-
})
815-
816806
domainutil.RepairInfo.SetRepairMode(cfg.RepairMode)
817807
domainutil.RepairInfo.SetRepairTableList(cfg.RepairTableList)
818808
executor.GlobalDiskUsageTracker.SetBytesLimit(cfg.TempStorageQuota)

pkg/config/config_test.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -743,11 +743,6 @@ grpc-keepalive-timeout = 0.2
743743
[tikv-client.async-commit]
744744
keys-limit=123
745745
total-key-size-limit=1024
746-
[tikv-client.circuit-breaker.pd-region-metadata]
747-
error-rate-evaluation-window-seconds = 50
748-
min-qps-to-open=15
749-
cooldown-interval-seconds=25
750-
half-open-success-count=5
751746
[experimental]
752747
allow-expression-index = true
753748
[isolation-read]
@@ -789,11 +784,6 @@ max_connections = 200
789784
require.Equal(t, uint64(1024), conf.TiKVClient.AsyncCommit.TotalKeySizeLimit)
790785
require.Equal(t, uint(128), conf.TiKVClient.MaxBatchSize)
791786
require.Equal(t, uint(6000), conf.TiKVClient.RegionCacheTTL)
792-
cbSettings := conf.TiKVClient.CircuitBreakerSettingsList.PDRegionsMetadata
793-
require.Equal(t, uint(50), cbSettings.ErrorRateEvaluationWindowSeconds)
794-
require.Equal(t, uint(15), cbSettings.MinQPSToOpen)
795-
require.Equal(t, uint(25), cbSettings.CooldownIntervalSeconds)
796-
require.Equal(t, uint(5), cbSettings.HalfOpenSuccessCount)
797787
require.Equal(t, int64(0), conf.TiKVClient.StoreLimit)
798788
require.Equal(t, int64(8192), conf.TiKVClient.TTLRefreshedTxnSize)
799789
require.Equal(t, time.Millisecond*200, conf.TiKVClient.GetGrpcKeepAliveTimeout())

0 commit comments

Comments
 (0)