planner: fix wrong extend predicate simplification for subquery and nested expressions

Signed-off-by: Weizhen Wang <[email protected]>

Author: hawkingrei

pkg/planner/core/issuetest/BUILD.bazel

@@ -10,7 +10,7 @@ go_test(
     data = glob(["testdata/**"]),
     flaky = True,
     race = "on",
-    shard_count = 7,
+    shard_count = 8,
     deps = [
         "//pkg/parser",
         "//pkg/planner",

pkg/planner/core/issuetest/planner_issue_test.go

@@ -231,3 +231,32 @@ ON base.c1 <=> base2.c1;`).Sort().Check(testkit.Rows(
 		"1 Alice 1 100",
 		"<nil> Bob <nil> <nil>"))
 }
+
+func TestIssue58451(t *testing.T) {
+	store := testkit.CreateMockStore(t)
+	tk := testkit.NewTestKit(t, store)
+	tk.MustExec("use test;")
+	tk.MustExec("create table t1 (a1 int, b1 int);")
+	tk.MustExec("insert into t1 values(1,1);")
+	tk.MustQuery(`explain
+SELECT (4,5) IN (SELECT 8,0 UNION SELECT 8, 8) AS field1
+FROM t1 AS table1
+WHERE (EXISTS (SELECT SUBQUERY2_t1.a1 AS SUBQUERY2_field1 FROM t1 AS SUBQUERY2_t1)) OR table1.b1 >= 55
+GROUP BY field1;`).Check(testkit.Rows("HashJoin_34 2.00 root  CARTESIAN left outer semi join, left side:HashAgg_35",
+		"├─HashAgg_59(Build) 2.00 root  group by:Column#18, Column#19, funcs:firstrow(1)->Column#45",
+		"│ └─Union_63 0.00 root  ",
+		"│   ├─Projection_65 0.00 root  8->Column#18, 0->Column#19",
+		"│   │ └─TableDual_66 0.00 root  rows:0",
+		"│   └─Projection_67 0.00 root  8->Column#18, 8->Column#19",
+		"│     └─TableDual_68 0.00 root  rows:0",
+		"└─HashAgg_35(Probe) 2.00 root  group by:Column#10, funcs:firstrow(1)->Column#42",
+		"  └─HashJoin_36 10000.00 root  CARTESIAN left outer semi join, left side:TableReader_38",
+		"    ├─HashAgg_41(Build) 2.00 root  group by:Column#8, Column#9, funcs:firstrow(1)->Column#44",
+		"    │ └─Union_45 0.00 root  ",
+		"    │   ├─Projection_47 0.00 root  8->Column#8, 0->Column#9",
+		"    │   │ └─TableDual_48 0.00 root  rows:0",
+		"    │   └─Projection_49 0.00 root  8->Column#8, 8->Column#9",
+		"    │     └─TableDual_50 0.00 root  rows:0",
+		"    └─TableReader_38(Probe) 10000.00 root  data:TableFullScan_37",
+		"      └─TableFullScan_37 10000.00 cop[tikv] table:table1 keep order:false, stats:pseudo"))
+}

pkg/planner/core/rule_decorrelate.go

@@ -160,7 +160,15 @@ func pruneRedundantApply(p base.LogicalPlan) (base.LogicalPlan, bool) {
 	if apply.JoinType != logicalop.LeftOuterJoin && apply.JoinType != logicalop.LeftOuterSemiJoin {
 		return nil, false
 	}
-
+	// add a strong limit for fix the https://github.com/pingcap/tidb/issues/58451. we can remove it when to have better implememnt.
+	// But this problem has affected tiflash CI.
+	applyChildren := apply.Children()
+	if len(applyChildren) >= 2 {
+		corCols := coreusage.ExtractCorColumnsBySchema4LogicalPlan(applyChildren[1], applyChildren[0].Schema())
+		if len(corCols) == 0 {
+			return nil, false
+		}
+	}
 	// Simplify predicates from the LogicalSelection
 	simplifiedPredicates := applyPredicateSimplification(p.SCtx(), logicalSelection.Conditions)
 

tests/integrationtest/r/planner/core/casetest/predicate_simplification.result

@@ -353,9 +353,13 @@ Projection	8000.00	root		1->Column#10
 explain format=brief
 SELECT 1 FROM t1 AS tab WHERE 1 = 1 OR a1 in (select a2 from t2);
 id	estRows	task	access object	operator info
-Projection	10000.00	root		1->Column#9
-└─TableReader	10000.00	root		data:TableFullScan
-  └─TableFullScan	10000.00	cop[tikv]	table:tab	keep order:false, stats:pseudo
+Projection	8000.00	root		1->Column#9
+└─Selection	8000.00	root		or(1, Column#8)
+  └─HashJoin	10000.00	root		CARTESIAN left outer semi join, left side:TableReader, other cond:eq(planner__core__casetest__predicate_simplification.t1.a1, planner__core__casetest__predicate_simplification.t2.a2)
+    ├─TableReader(Build)	10000.00	root		data:TableFullScan
+    │ └─TableFullScan	10000.00	cop[tikv]	table:t2	keep order:false, stats:pseudo
+    └─TableReader(Probe)	10000.00	root		data:TableFullScan
+      └─TableFullScan	10000.00	cop[tikv]	table:tab	keep order:false, stats:pseudo
 explain format=brief
 SELECT 1 FROM t1
 WHERE