Skip to content

Commit 99deeb3

Browse files
authored
test: fix TestFailBusyServerCop and TestRequestSource for nextgen (#63340)
close #63339
1 parent feba12d commit 99deeb3

File tree

4 files changed

+8
-81
lines changed

4 files changed

+8
-81
lines changed

pkg/session/test/session_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -709,6 +709,10 @@ func TestRequestSource(t *testing.T) {
709709
case *kvrpcpb.BatchGetRequest:
710710
readType = "leader_" // read request will be attached with read type
711711
requestSource = r.GetContext().GetRequestSource()
712+
case *kvrpcpb.PessimisticLockRequest:
713+
requestSource = r.GetContext().GetRequestSource()
714+
default:
715+
fmt.Printf("unexpected request type %T\n", r)
712716
}
713717
require.Equal(t, readType+source, requestSource)
714718
return next(target, req)

pkg/store/driver/BUILD.bazel

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,10 @@ go_test(
4747
flaky = True,
4848
shard_count = 8,
4949
deps = [
50-
"//pkg/config",
51-
"//pkg/ddl",
52-
"//pkg/domain",
5350
"//pkg/kv",
5451
"//pkg/session",
55-
"//pkg/store/copr",
5652
"//pkg/store/mockstore",
57-
"//pkg/store/mockstore/unistore",
53+
"//pkg/testkit",
5854
"//pkg/testkit/testsetup",
5955
"//pkg/util",
6056
"//pkg/util/tracing",

pkg/store/driver/main_test.go

Lines changed: 0 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -16,28 +16,15 @@ package driver
1616

1717
import (
1818
"context"
19-
"flag"
20-
"fmt"
2119
"testing"
2220

23-
"github.com/pingcap/tidb/pkg/config"
24-
"github.com/pingcap/tidb/pkg/ddl"
25-
"github.com/pingcap/tidb/pkg/domain"
2621
"github.com/pingcap/tidb/pkg/kv"
27-
"github.com/pingcap/tidb/pkg/session"
28-
"github.com/pingcap/tidb/pkg/store/copr"
29-
"github.com/pingcap/tidb/pkg/store/mockstore/unistore"
3022
"github.com/pingcap/tidb/pkg/testkit/testsetup"
3123
"github.com/stretchr/testify/require"
3224
"github.com/tikv/client-go/v2/tikv"
3325
"go.uber.org/goleak"
3426
)
3527

36-
var (
37-
pdAddrs = flag.String("pd-addrs", "127.0.0.1:2379", "pd addrs")
38-
withTiKV = flag.Bool("with-tikv", false, "run tests with TiKV cluster started. (not use the mock server)")
39-
)
40-
4128
func TestMain(m *testing.M) {
4229
testsetup.SetupForCommonTest()
4330
tikv.EnableFailpoints()
@@ -52,67 +39,6 @@ func TestMain(m *testing.M) {
5239
goleak.VerifyTestMain(m, opts...)
5340
}
5441

55-
func createTestStore(t *testing.T) (kv.Storage, *domain.Domain) {
56-
if *withTiKV {
57-
return createTiKVStore(t)
58-
}
59-
return createUnistore(t)
60-
}
61-
62-
func createTiKVStore(t *testing.T) (kv.Storage, *domain.Domain) {
63-
var d TiKVDriver
64-
store, err := d.Open(fmt.Sprintf("tikv://%s", *pdAddrs))
65-
require.NoError(t, err)
66-
config.GetGlobalConfig().Store = config.StoreTypeTiKV
67-
require.NoError(t, ddl.StartOwnerManager(context.Background(), store))
68-
// clear storage
69-
txn, err := store.Begin()
70-
require.NoError(t, err)
71-
iter, err := txn.Iter(nil, nil)
72-
require.NoError(t, err)
73-
for iter.Valid() {
74-
require.NoError(t, txn.Delete(iter.Key()))
75-
require.NoError(t, iter.Next())
76-
}
77-
require.NoError(t, txn.Commit(context.Background()))
78-
79-
session.ResetStoreForWithTiKVTest(store)
80-
81-
dom, err := session.BootstrapSession(store)
82-
require.NoError(t, err)
83-
84-
t.Cleanup(func() {
85-
dom.Close()
86-
ddl.CloseOwnerManager(store)
87-
require.NoError(t, store.Close())
88-
})
89-
90-
return store, dom
91-
}
92-
93-
func createUnistore(t *testing.T) (kv.Storage, *domain.Domain) {
94-
client, pdClient, cluster, err := unistore.New("", nil, nil)
95-
require.NoError(t, err)
96-
97-
unistore.BootstrapWithSingleStore(cluster)
98-
kvStore, err := tikv.NewTestTiKVStore(client, pdClient, nil, nil, 0)
99-
require.NoError(t, err)
100-
101-
coprStore, err := copr.NewStore(kvStore, nil)
102-
require.NoError(t, err)
103-
104-
store := &tikvStore{KVStore: kvStore, coprStore: coprStore}
105-
dom, err := session.BootstrapSession(store)
106-
require.NoError(t, err)
107-
108-
t.Cleanup(func() {
109-
dom.Close()
110-
require.NoError(t, store.Close())
111-
})
112-
113-
return store, dom
114-
}
115-
11642
func prepareSnapshot(t *testing.T, store kv.Storage, data [][]any) kv.Snapshot {
11743
txn, err := store.Begin()
11844
require.NoError(t, err)

pkg/store/driver/sql_fail_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package driver
15+
package driver_test
1616

1717
import (
1818
"context"
@@ -21,12 +21,13 @@ import (
2121

2222
"github.com/pingcap/failpoint"
2323
"github.com/pingcap/tidb/pkg/session"
24+
"github.com/pingcap/tidb/pkg/testkit"
2425
"github.com/pingcap/tidb/pkg/util"
2526
"github.com/stretchr/testify/require"
2627
)
2728

2829
func TestFailBusyServerCop(t *testing.T) {
29-
store, _ := createTestStore(t)
30+
store := testkit.CreateMockStore(t)
3031

3132
se, err := session.CreateSession4Test(store)
3233
require.NoError(t, err)

0 commit comments

Comments
 (0)