avoid complaining about the binary collation in prepare

Signed-off-by: Yang Keao <[email protected]>

Author: YangKeao

pkg/parser/mysql/errcode.go

@@ -898,6 +898,7 @@ const (
 	ErrInvalidJSONText                                       = 3140
 	ErrInvalidJSONTextInParam                                = 3141
 	ErrInvalidJSONPath                                       = 3143
+	ErrInvalidJSONCharset                                    = 3144
 	ErrInvalidTypeForJSON                                    = 3146
 	ErrInvalidJSONPathWildcard                               = 3149
 	ErrInvalidJSONContainsPathType                           = 3150

pkg/parser/mysql/errname.go

@@ -907,6 +907,7 @@ var MySQLErrName = map[uint16]*ErrMessage{
 	ErrInvalidJSONText:                                       Message("Invalid JSON text: %-.192s", nil),
 	ErrInvalidJSONTextInParam:                                Message("Invalid JSON text in argument %d to function %s: \"%s\" at position %d.", nil),
 	ErrInvalidJSONPath:                                       Message("Invalid JSON path expression %s.", nil),
+	ErrInvalidJSONCharset:                                    Message("Cannot create a JSON value from a string with CHARACTER SET '%s'.", nil),
 	ErrInvalidTypeForJSON:                                    Message("Invalid data type for JSON data in argument %d to function %s; a JSON string or JSON type is required.", nil),
 	ErrInvalidJSONPathWildcard:                               Message("In this situation, path expressions may not contain the * and ** tokens or an array range.", nil),
 	ErrInvalidJSONContainsPathType:                           Message("The second argument can only be either 'one' or 'all'.", nil),

pkg/parser/mysql/state.go

@@ -254,6 +254,7 @@ var MySQLState = map[uint16]string{
 	ErrInvalidJSONText:                     "22032",
 	ErrInvalidJSONTextInParam:              "22032",
 	ErrInvalidJSONPath:                     "42000",
+	ErrInvalidJSONCharset:                  "22032",
 	ErrInvalidJSONData:                     "22032",
 	ErrInvalidJSONPathWildcard:             "42000",
 	ErrJSONUsedAsKey:                       "42000",

pkg/types/field_type.go

@@ -197,6 +197,10 @@ func InferParamTypeFromUnderlyingValue(value any, tp *FieldType) {
 		tp.SetType(mysql.TypeVarString)
 		tp.SetFlen(UnspecifiedLength)
 		tp.SetDecimal(UnspecifiedLength)
+		// Also set the `charset` and `collation` for it, because some function (e.g. `json_object`) will return error
+		// if the argument collation is `binary`.
+		tp.SetCharset(mysql.DefaultCharset)
+		tp.SetCollate(mysql.DefaultCollationName)
 	default:
 		DefaultTypeForValue(value, tp, mysql.DefaultCharset, mysql.DefaultCollationName)
 		if hasVariantFieldLength(tp) {

tests/integrationtest/r/expression/json.result

@@ -518,9 +518,9 @@ select json_objectagg(a, b) from t;
 json_objectagg(a, b)
 {"a string": "base64:type252:YSBiaW5hcnkgc3RyaW5n"}
 select json_object(b, a) from t;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 select json_objectagg(b, a) from t;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 select cast(cast(b'010101' as json) as signed);
 cast(cast(b'010101' as json) as signed)
 0
@@ -785,30 +785,35 @@ Error 3146 (22032): Invalid data type for JSON data in argument 1 to function js
 SELECT JSON_TYPE(b1) FROM t1;
 Error 3146 (22032): Invalid data type for JSON data in argument 1 to function json_type; a JSON string or JSON type is required.
 SELECT JSON_TYPE(b2) FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT JSON_EXTRACT(b2, '$') FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT JSON_MERGE(b2, '{a:"b"}') FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT JSON_CONTAINS_PATH(b2, 'one', '$.a') FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT '1' member of(b2) FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT JSON_CONTAINS(b2, '{a:"b"}') FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT JSON_OVERLAPS(b2, '{a:"b"}') FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT JSON_MERGE_PATCH(b2, '{a:"b"}') FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT JSON_MERGE_PATCH('{a:"b"}', b2) FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT JSON_MERGE_PRESERVE(b2, '{a:"b"}') FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT JSON_MERGE_PRESERVE('{a:"b"}', b2) FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT JSON_SEARCH(b2, 'one', '1') FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT JSON_KEYS(b2) FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
 SELECT JSON_SCHEMA_VALID(b2, '{}') FROM t1;
-Error 3144 (HY000): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+Error 3144 (22032): Cannot create a JSON value from a string with CHARACTER SET 'binary'.
+prepare stmt from 'select json_object(?, ?)';
+set @a=1;
+execute stmt using @a, @a;
+json_object(?, ?)
+{"1": 1}

tests/integrationtest/t/expression/json.test

@@ -533,3 +533,8 @@ SELECT JSON_SEARCH(b2, 'one', '1') FROM t1;
 SELECT JSON_KEYS(b2) FROM t1;
 -- error 3144
 SELECT JSON_SCHEMA_VALID(b2, '{}') FROM t1;
+
+# TestIssue54044
+prepare stmt from 'select json_object(?, ?)';
+set @a=1;
+execute stmt using @a, @a;