address comment about time

Signed-off-by: Wenqi Mou <[email protected]>

Author: Tristan1900

br/pkg/registry/registration.go

@@ -63,7 +63,7 @@ const (
 	// resumeTaskByIDSQLTemplate is the SQL template for resuming a paused task by its ID
 	resumeTaskByIDSQLTemplate = `
 		UPDATE %s.%s
-		SET status = 'running', last_heartbeat = %%?
+		SET status = 'running', last_heartbeat_ts = %%?
 		WHERE id = %%?`
 
 	// deleteRegistrationSQLTemplate is the SQL template for deleting a registration
@@ -81,7 +81,7 @@ const (
 	createNewTaskSQLTemplate = `
 		INSERT INTO %s.%s
 		(filter_strings, filter_hash, start_ts, restored_ts, upstream_cluster_id,
-		 with_sys_table, status, cmd, start_timestamp, last_heartbeat)
+		 with_sys_table, status, cmd, task_start_ts, last_heartbeat_ts)
 		VALUES (%%?, MD5(%%?), %%?, %%?, %%?, %%?, 'running', %%?, %%?, %%?)`
 )
 
@@ -126,6 +126,11 @@ type Registry struct {
 	heartbeatManager *HeartbeatManager
 }
 
+// getCurrentTimestamp returns the current time as time.Time
+func getCurrentTimestamp() time.Time {
+	return time.Now()
+}
+
 // NewRestoreRegistry creates a new registry using TiDB's session
 func NewRestoreRegistry(g glue.Glue, dom *domain.Domain) (*Registry, error) {
 	se, err := g.CreateSession(dom.Store())
@@ -236,7 +241,7 @@ func (r *Registry) ResumeOrCreateRegistration(ctx context.Context, info Registra
 
 			// strictly check for paused status
 			if status == string(TaskStatusPaused) {
-				currentTime := uint64(time.Now().Unix())
+				currentTime := getCurrentTimestamp()
 				updateSQL := fmt.Sprintf(resumeTaskByIDSQLTemplate, RestoreRegistryDBName, RestoreRegistryTableName)
 				_, _, err = execCtx.ExecRestrictedSQL(ctx, sessionOpts, updateSQL, currentTime, existingTaskID)
 				if err != nil {
@@ -260,7 +265,7 @@ func (r *Registry) ResumeOrCreateRegistration(ctx context.Context, info Registra
 		}
 
 		// no existing task found, create a new one
-		currentTime := uint64(time.Now().Unix())
+		currentTime := getCurrentTimestamp()
 		insertSQL := fmt.Sprintf(createNewTaskSQLTemplate, RestoreRegistryDBName, RestoreRegistryTableName)
 		_, _, err = execCtx.ExecRestrictedSQL(ctx, sessionOpts, insertSQL,
 			filterStrings, filterStrings, info.StartTS, info.RestoredTS,

pkg/session/bootstrap.go

@@ -741,8 +741,8 @@ const (
 		with_sys_table BOOLEAN NOT NULL DEFAULT TRUE,
 		status VARCHAR(20) NOT NULL DEFAULT 'running',
 		cmd TEXT,
-		start_timestamp BIGINT UNSIGNED NOT NULL,
-		last_heartbeat BIGINT UNSIGNED NOT NULL,
+		task_start_ts TIMESTAMP(6) DEFAULT CURRENT_TIMESTAMP(6),
+		last_heartbeat_ts TIMESTAMP(6) DEFAULT CURRENT_TIMESTAMP(6),
 		UNIQUE KEY unique_registration_params (
 			filter_hash,
 			start_ts,