Skip to content

Commit fd21de7

Browse files
xzhangxian1008RidRisR
authored andcommitted
executor: reset groupCount when Close is called in streamagg executor (#53874)
close #53867
1 parent aac9fb0 commit fd21de7

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

pkg/executor/internal/vecgroupchecker/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ go_test(
2222
],
2323
embed = [":vecgroupchecker"],
2424
flaky = True,
25-
shard_count = 3,
25+
shard_count = 4,
2626
deps = [
2727
"//pkg/config",
2828
"//pkg/expression",

pkg/executor/internal/vecgroupchecker/vec_group_checker.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -496,6 +496,7 @@ func (e *VecGroupChecker) IsExhausted() bool {
496496
func (e *VecGroupChecker) Reset() {
497497
if e.groupOffset != nil {
498498
e.groupOffset = e.groupOffset[:0]
499+
e.groupCount = 0
499500
}
500501
if e.sameGroup != nil {
501502
e.sameGroup = e.sameGroup[:0]

pkg/executor/internal/vecgroupchecker/vec_group_checker_test.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,3 +268,13 @@ func TestVecGroupChecker(t *testing.T) {
268268
require.Equal(t, e, 3)
269269
require.True(t, groupChecker.IsExhausted())
270270
}
271+
272+
func TestIssue53867(t *testing.T) {
273+
checker := NewVecGroupChecker(nil, true, nil)
274+
checker.groupOffset = make([]int, 20)
275+
checker.nextGroupID = 10
276+
checker.groupCount = 15
277+
require.False(t, checker.IsExhausted())
278+
checker.Reset()
279+
require.True(t, checker.IsExhausted())
280+
}

0 commit comments

Comments
 (0)