Fix the issue that window function returns incorrect result when range type frame end is preceding (#10238)

close #10236

Remove a wrong judgement

Author: xzhangxian1008

dbms/src/DataStreams/WindowTransformAction.cpp

@@ -660,10 +660,12 @@ std::tuple<RowNumber, bool> WindowTransformAction::stepToStartForRangeFrame()
 
 std::tuple<RowNumber, bool> WindowTransformAction::stepToEndForRangeFrame()
 {
-    if (!window_description.frame.end_preceding && !partition_ended)
-        // If we find the frame end and the partition_ended is false.
-        // Some previous blocks may be dropped, this is an unexpected behaviour.
-        // So, we shouldn't do anything before the partition_ended is true.
+    auto end_preceding = window_description.frame.end_preceding;
+    if ((!end_preceding || (end_preceding && window_description.frame.end_offset == 0)) && !partition_ended)
+        // Still return false even when end_preceding is true and end_offset == 0, because there may still
+        // same rows as current_row in the next block. So we cannot stop find the frame
+        // end until got the partition end(or got the first row that is greater than
+        // current_row).
         return std::make_tuple(RowNumber(), false);
 
     if (window_description.is_desc)

dbms/src/WindowFunctions/tests/gtest_agg.cpp

@@ -738,4 +738,39 @@ try
 }
 CATCH
 
+TEST_F(WindowAggFuncTest, issue10236)
+try
+{
+    MockWindowFrame frame;
+    frame.type = tipb::WindowFrameType::Ranges;
+    frame.start = buildRangeFrameBound(
+        tipb::WindowBoundType::Preceding,
+        tipb::RangeCmpDataType::Int,
+        ORDER_COL_NAME,
+        false,
+        static_cast<Int64>(0));
+
+    std::vector<tipb::WindowBoundType> window_bound_types{
+        tipb::WindowBoundType::Preceding,
+        tipb::WindowBoundType::Following};
+
+    for (auto window_bound_type : window_bound_types)
+    {
+        frame.end = buildRangeFrameBound(
+            window_bound_type,
+            tipb::RangeCmpDataType::Int,
+            ORDER_COL_NAME,
+            false,
+            static_cast<Int64>(0));
+
+        executeFunctionAndAssert(
+            toNullableVec<Int64>(std::vector<std::optional<Int64>>{10, 10, 10, 10, 10, 10, 10, 10, 10, 10}),
+            Count(value_col),
+            {toVec<Int64>({0, 0, 0, 0, 0, 0, 0, 0, 0, 0}),
+             toVec<Int64>({0, 0, 0, 0, 0, 0, 0, 0, 0, 0}),
+             toVec<Int64>({0, 0, 0, 0, 0, 0, 0, 0, 0, 0})},
+            frame);
+    }
+}
+CATCH
 } // namespace DB::tests