Skip to content

Commit f12049b

Browse files
authored
eventfilter: simplify the way to eval virtual column (#12229)
close #12230
1 parent 4b2c47d commit f12049b

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

pkg/filter/expr_filter.go

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -337,19 +337,13 @@ func (r *dmlExprFilterRule) buildRowWithVirtualColumns(
337337
if err != nil {
338338
return chunk.Row{}, err
339339
}
340-
var fts []*types.FieldType
341-
for _, col := range columns {
342-
fts = append(fts, col.GetType(r.sessCtx.GetExprCtx().GetEvalCtx()))
343-
}
344-
ch := chunk.NewEmptyChunk(fts)
345-
ch.AppendRow(row)
346340

347341
vColOffsets, vColFts := collectVirtualColumnOffsetsAndTypes(r.sessCtx.GetExprCtx().GetEvalCtx(), columns)
348-
err = table.FillVirtualColumnValue(vColFts, vColOffsets, columns, tableInfo.Columns, r.sessCtx.GetExprCtx(), ch)
342+
err = table.FillVirtualColumnValue(vColFts, vColOffsets, columns, tableInfo.Columns, r.sessCtx.GetExprCtx(), row.Chunk())
349343
if err != nil {
350344
return chunk.Row{}, err
351345
}
352-
return ch.GetRow(0), nil
346+
return row, nil
353347
}
354348

355349
func collectVirtualColumnOffsetsAndTypes(ctx expression.EvalContext, cols []*expression.Column) ([]int, []*types.FieldType) {

0 commit comments

Comments
 (0)