Skip to content

Commit 65ae375

Browse files
authored
Remove support for sx from BranchName component (#6625)
1 parent 7d7b797 commit 65ae375

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

.changeset/strange-peas-kiss.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": major
3+
---
4+
5+
Update BranchName component to no longer support sx

packages/react/src/BranchName/BranchName.docs.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,6 @@
2424
"name": "as",
2525
"type": "React.ElementType",
2626
"defaultValue": "\"a\""
27-
},
28-
{
29-
"name": "sx",
30-
"type": "SystemStyleObject",
31-
"deprecated": true
3227
}
3328
],
3429
"subcomponents": []

packages/react/src/BranchName/BranchName.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,20 @@
11
import React, {type ForwardedRef} from 'react'
22
import {clsx} from 'clsx'
3-
import type {SxProp} from '../sx'
43
import classes from './BranchName.module.css'
5-
import {BoxWithFallback} from '../internal/components/BoxWithFallback'
64

75
type BranchNameProps<As extends React.ElementType> = {
86
as?: As
9-
} & DistributiveOmit<React.ComponentPropsWithRef<React.ElementType extends As ? 'a' : As>, 'as'> &
10-
Omit<SxProp, 'sx'> &
11-
SxProp
7+
} & DistributiveOmit<React.ComponentPropsWithRef<React.ElementType extends As ? 'a' : As>, 'as'> & {
8+
className?: string
9+
}
1210

1311
// eslint-disable-next-line @typescript-eslint/no-explicit-any
1412
function BranchName<As extends React.ElementType>(props: BranchNameProps<As>, ref: ForwardedRef<any>) {
1513
const {as: Component = 'a', className, children, ...rest} = props
1614
return (
17-
<BoxWithFallback as={Component} {...rest} ref={ref} className={clsx(className, classes.BranchName)}>
15+
<Component {...rest} ref={ref} className={clsx(className, classes.BranchName)}>
1816
{children}
19-
</BoxWithFallback>
17+
</Component>
2018
)
2119
}
2220

0 commit comments

Comments
 (0)