How do I do a github-actions replacement with a sub-path?

[TWiStErRob]

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

If you're self-hosting Renovate, select which platform you are using.

github.com

What is your question?

Example repo:
https://github.com/TWiStErRob/renovate-replacement-test (archived contents at https://github.com/TWiStErRob/repros/tree/main/renovate/replacementName-github-actions-path)

Want to replace https://github.com/gradle/gradle-build-action with https://github.com/gradle/actions/tree/main/setup-gradle automatically, as documented at https://github.com/gradle/gradle-build-action/releases/tag/v3.0.0.

GitHub Action usage:

      - uses: gradle/gradle-build-action@v3

Replacement rule:

	"packageRules": [
		{
			"matchManagers": ["github-actions"],
			"matchPackageNames": ["gradle/gradle-build-action"],
			"replacementName": "gradle/actions/setup-gradle",
			"replacementVersion": "3.0.0"
		}
	]

but this fails and doesn't open a PR:

It finds the dependency though:

Logs (if relevant)

Logs

https://developer.mend.io/github/TWiStErRob/renovate-replacement-test/-/job/8465efaa-0b10-43b2-a90e-d8fcc634a194

DEBUG: 1 flattened updates found: gradle/gradle-build-action
DEBUG: Returning 1 branch(es)
DEBUG: config.repoIsOnboarded=true
DEBUG: packageFiles with updates
{
  "baseBranch": "main"
  "config": {
    "github-actions": [
      {
        "deps": [
          {
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # {{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "commitMessageTopic": "{{{depName}}} action",
            "currentValue": "v3",
            "currentVersion": "v3",
            "datasource": "github-tags",
            "depName": "gradle/gradle-build-action",
            "depType": "action",
            "fixedVersion": "v3",
            "packageName": "gradle/gradle-build-action",
            "registryUrl": "https://github.com",
            "replaceString": "gradle/gradle-build-action@v3",
            "sourceUrl": "https://github.com/gradle/gradle-build-action",
            "versioning": "docker",
            "warnings": [],
            "updates": [
              {
                "updateType": "replacement",
                "newName": "gradle/actions/setup-gradle",
                "newValue": "3.0.0",
                "branchName": "renovate/gradle-gradle-build-action-replacement"
              }
            ]
          },
          {
            "autoReplaceStringTemplate": "{{depName}}-{{newValue}}",
            "currentValue": "latest",
            "datasource": "github-runners",
            "depName": "ubuntu",
            "depType": "github-runner",
            "packageName": "ubuntu",
            "replaceString": "ubuntu-latest",
            "skipReason": "invalid-version",
            "updates": []
          }
        ],
        "packageFile": ".github/workflows/build.yml"
      }
    ]
  }
}

DEBUG: detectSemanticCommits()
DEBUG: semanticCommits: returning "disabled" from cache
DEBUG: processRepo()
DEBUG: Processing 1 branch: renovate/gradle-gradle-build-action-replacement
DEBUG: Calculating hourly PRs remaining
DEBUG: currentHourStart=2024-02-07T09:00:00.000+00:00
DEBUG: PR hourly limit remaining: 2
DEBUG: Calculating prConcurrentLimit (10)
DEBUG: getBranchPr(renovate/gradle-gradle-build-action-replacement)
DEBUG: findPr(renovate/gradle-gradle-build-action-replacement, undefined, open)
DEBUG: findPr(renovate/gradle-gradle-build-action-replacement, undefined, closed)
DEBUG: 0 PRs are currently open
DEBUG: PR concurrent limit remaining: 10
DEBUG: Calculated maximum PRs remaining this run: 2
DEBUG: PullRequests limit = 2
DEBUG: Calculating hourly PRs remaining
DEBUG: currentHourStart=2024-02-07T09:00:00.000+00:00
DEBUG: PR hourly limit remaining: 2
DEBUG: Calculating branchConcurrentLimit (10)
DEBUG: 0 already existing branches found: 
DEBUG: Branch concurrent limit remaining: 10
DEBUG: Calculated maximum branches remaining this run: 2
DEBUG: Branches limit = 2
DEBUG: syncBranchState() (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: getBranchPr(renovate/gradle-gradle-build-action-replacement) (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: findPr(renovate/gradle-gradle-build-action-replacement, undefined, open) (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: findPr(renovate/gradle-gradle-build-action-replacement, undefined, closed) (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: branchExists=false (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: dependencyDashboardCheck=undefined (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: Check for closed PR because recreating closed PRs is disabled. (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: findPr(renovate/gradle-gradle-build-action-replacement, Replace gradle/gradle-build-action action with gradle/actions/setup-gradle 3.0.0, !open) (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: prAlreadyExisted=false (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: Checking schedule(at any time, null) (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: No schedule defined (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: Branch needs creating (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: Using reuseExistingBranch: false (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: Setting current branch to main (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: latest commit (branch="renovate/gradle-gradle-build-action-replacement")
{
  "branchName": "main"
  "latestCommitDate": "2024-02-07T09:33:28+00:00"
}

DEBUG: manager.getUpdatedPackageFiles() reuseExistingBranch=false (branch="renovate/gradle-gradle-build-action-replacement")
DEBUG: Starting search at index 93 (branch="renovate/gradle-gradle-build-action-replacement")
{
  "packageFile": ".github/workflows/build.yml"
  "depName": "gradle/gradle-build-action"
}

DEBUG: Found match at index 93 (branch="renovate/gradle-gradle-build-action-replacement")
{
  "packageFile": ".github/workflows/build.yml"
  "depName": "gradle/gradle-build-action"
}

DEBUG: depName mismatch (branch="renovate/gradle-gradle-build-action-replacement")
{
  "manager": "github-actions"
  "packageFile": ".github/workflows/build.yml"
  "currentDepName": "gradle/gradle-build-action"
  "newDepName": "gradle/actions"
}

WARN: Error updating branch: update failure (branch="renovate/gradle-gradle-build-action-replacement")

[rarkins]

I added extra fields to the debug message before the WARN, you can see:

DEBUG: depName mismatch (repository=renovate-reproductions/27107, packageFile=.github/workflows/build.yml, branch=renovate/gradle-gradle-build-action-replacement)
       "manager": "github-actions",
       "currentDepName": "gradle/gradle-build-action",
       "currentPackageName": "gradle/gradle-build-action",
       "newName": "gradle/actions/setup-gradle",
       "newContent": "on:\n  workflow_dispatch:\n\njobs:\n  build:\n    runs-on: ubuntu-latest\n    steps:\n      - uses: gradle/actions/[email protected]\n",
       "newUpgrade": {
         "depName": "gradle/actions",
         "commitMessageTopic": "{{{depName}}} action",
         "datasource": "github-tags",
         "versioning": "docker",
         "depType": "action",
         "replaceString": "gradle/actions/[email protected]",
         "autoReplaceStringTemplate": "{{depName}}/setup-gradle@{{#if newDigest}}{{newDigest}}{{#if newValue}} # {{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
         "currentValue": "3.0.0"
       }
 WARN: Error updating branch: update failure (repository=renovate-reproductions/27107, branch=renovate/gradle-gradle-build-action-replacement)

So after replacing, Renovate is seeing gradle/actions and not gradle/actions/setup-gradle as the extracted depName. I'm not sure we can add any simple substring check here without breaking other managers where that wouldn't be valid

[TWiStErRob]

But that seems correct. gradle/actions IS the new dependency name, because it represents a GitHub repo. The version/tag/hash is valid on that level.

All the values in the debug message are correct!

But because we can reference folders in a repo, we need the ability to express that. Maybe my original rule shouldn't use replacementName but something else or a combination of things?