Skip to content

Commit cd77f36

Browse files
authored
fix: requests without user-agent causing error 500 (#7749)
1 parent 1b6c67e commit cd77f36

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

server/controllers/auth.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,7 @@ router.all('/login/:strategy/callback', async (req, res, next) => {
9494
*/
9595
router.post('/login', bruteforce.prevent, async (req, res, next) => {
9696
_.set(res.locals, 'pageMeta.title', 'Login')
97-
98-
if (req.query.legacy || req.get('user-agent').indexOf('Trident') >= 0) {
97+
if (req.query.legacy || (req.get('user-agent') && req.get('user-agent').indexOf('Trident') >= 0)) {
9998
try {
10099
const authResult = await WIKI.models.users.login({
101100
strategy: req.body.strategy,

server/controllers/common.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ router.get('/*', async (req, res, next) => {
507507
injectCode.body = `${injectCode.body}\n${page.extra.js}`
508508
}
509509

510-
if (req.query.legacy || req.get('user-agent').indexOf('Trident') >= 0) {
510+
if (req.query.legacy || (req.get('user-agent') && req.get('user-agent').indexOf('Trident') >= 0)) {
511511
// -> Convert page TOC
512512
if (_.isString(page.toc)) {
513513
page.toc = JSON.parse(page.toc)

0 commit comments

Comments
 (0)