Merge pull request #233 from danielgtaylor/hide-secrets-input

danielgtaylor · web-flow · commit 21a9017df946 · 2023-12-14T13:46:40.000-08:00
fix: hide secret input during API config, fixes #232
diff --git a/cli/interactive.go b/cli/interactive.go
@@ -43,7 +43,12 @@ func (a defaultAsker) askInput(message string, def string, required bool, help s
 		message += " (optional)"
 	}
 
-	err := survey.AskOne(&survey.Input{Message: message, Default: def, Help: help}, &resp, options...)
+	var prompt survey.Prompt = &survey.Input{Message: message, Default: def, Help: help}
+	if strings.Contains(message, "password") || strings.Contains(message, "secret") {
+		prompt = &survey.Password{Message: message, Help: help}
+	}
+
+	err := survey.AskOne(prompt, &resp, options...)
 	if err == terminal.InterruptErr {
 		os.Exit(0)
 	}

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,12 @@ func (a defaultAsker) askInput(message string, def string, required bool, help s`
`43`	`43`	`message += " (optional)"`
`44`	`44`	`}`
`45`	`45`
`46`		`- err := survey.AskOne(&survey.Input{Message: message, Default: def, Help: help}, &resp, options...)`
	`46`	`+ var prompt survey.Prompt = &survey.Input{Message: message, Default: def, Help: help}`
	`47`	`+ if strings.Contains(message, "password") \|\| strings.Contains(message, "secret") {`
	`48`	`+ prompt = &survey.Password{Message: message, Help: help}`
	`49`	`+ }`
	`50`	`+`
	`51`	`+ err := survey.AskOne(prompt, &resp, options...)`
`47`	`52`	`if err == terminal.InterruptErr {`
`48`	`53`	`os.Exit(0)`
`49`	`54`	`}`