fix: handle container_statuses being None

[johanneskoester]

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability by preventing errors when container statuses are missing from pods during job checks.

[coderabbitai]

📝 Walkthrough

Walkthrough

A conditional statement in the check_active_jobs async method was updated to include an explicit check that pods.items[0].status.container_statuses is not None before accessing it, preventing errors when container statuses are missing.

Changes

File(s)	Change Summary
snakemake_executor_plugin_kubernetes/init.py	Refined condition in check_active_jobs to check for non-None container statuses before access

Possibly related PRs

• fix: delete k8s jobs after failure (important in setups where the system attaches sidecar pods, which can otherwise remain after failure) #49: Modifies typing, error handling, and job deletion logic in the same check_active_jobs method, indicating both PRs directly improve this method's robustness.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f3723ec and 510be79.

📒 Files selected for processing (1)

• snakemake_executor_plugin_kubernetes/__init__.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.py`: Do not try to improve formatting. Do not suggest type annotations for...

**/*.py: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of the self argument of methods.
Do not suggest type annotation of the cls argument of classmethods.
Do not suggest return type annotation if a function or method does not contain a return statement.

⚙️ Source: CodeRabbit Configuration File

List of files the instruction was applied to:

• snakemake_executor_plugin_kubernetes/__init__.py

🧠 Learnings (1)

snakemake_executor_plugin_kubernetes/__init__.py (4)

Learnt from: johanneskoester
PR: snakemake/snakemake-executor-plugin-kubernetes#22
File: snakemake_executor_plugin_kubernetes/__init__.py:32-39
Timestamp: 2024-08-14T14:18:38.175Z
Learning: Do not suggest type annotation of the `self` argument of methods in the Snakemake executor plugin for Kubernetes.

Learnt from: johanneskoester
PR: snakemake/snakemake-executor-plugin-kubernetes#22
File: snakemake_executor_plugin_kubernetes/__init__.py:32-39
Timestamp: 2024-10-08T17:41:54.542Z
Learning: Do not suggest type annotation of the `self` argument of methods in the Snakemake executor plugin for Kubernetes.

Learnt from: johanneskoester
PR: snakemake/snakemake-executor-plugin-kubernetes#22
File: snakemake_executor_plugin_kubernetes/__init__.py:32-39
Timestamp: 2024-10-08T17:41:54.542Z
Learning: Exception messages in the Snakemake executor plugin for Kubernetes are defined correctly in the exception class constructor call, and should not be flagged as issues.

Learnt from: johanneskoester
PR: snakemake/snakemake-executor-plugin-kubernetes#22
File: snakemake_executor_plugin_kubernetes/__init__.py:32-39
Timestamp: 2024-08-14T14:18:38.175Z
Learning: Exception messages in the Snakemake executor plugin for Kubernetes are defined correctly in the exception class constructor call, and should not be flagged as issues.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: formatting
• GitHub Check: testing

🔇 Additional comments (1)

snakemake_executor_plugin_kubernetes/__init__.py (1)

451-451: Good defensive programming fix!

The addition of the null check for container_statuses correctly prevents potential runtime errors when the Kubernetes API returns pods without container status information. This aligns well with the existing fallback logic in the else block.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.