Skip to content

Commit 521505d

Browse files
Undo conditional skip of reanimated commits (#7867)
## Summary This PR reverts the conditional skip of reanimated commits (#7668). This breaks sticky headers, but fixes starvation issues, that would manifest on C++ state updates. To fix the stick header one must use the `DISABLE_COMMIT_PAUSING_MECHANISM` feature flag in reanimated and the `preventShadowTreeCommitExhaustionWithLocking` in react-native. ## Test plan
1 parent fdc1ebf commit 521505d

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

packages/react-native-reanimated/Common/cpp/reanimated/Fabric/ReanimatedCommitHook.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,7 @@ RootShadowNode::Unshared ReanimatedCommitHook::shadowTreeWillCommit(
9393
// it could lead to RN commits being delayed until the animation is finished
9494
// (very bad). We don't pause Reanimated commits for state updates coming
9595
// from React Native as this would break sticky header animations.
96-
#if REACT_NATIVE_MINOR_VERSION >= 80
97-
if (commitOptions.source == ShadowTreeCommitSource::React) {
98-
updatesRegistryManager_->pauseReanimatedCommits();
99-
}
100-
#else
10196
updatesRegistryManager_->pauseReanimatedCommits();
102-
#endif
10397
}
10498

10599
return rootNode;

0 commit comments

Comments
 (0)