Skip to content

Ship librocksdb.dll together with release binary on Windows #3662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2025
Merged

Ship librocksdb.dll together with release binary on Windows #3662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4697ac8
Ship librocksdb.dll together with release binary on Windows
jangko Sep 10, 2025
9541442
Merge branch 'master' into win-rocksdb-dll
jangko Sep 11, 2025
41e55c7
Trigger CI
jangko Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ VERIF_PROXY_OUT_PATH ?= build/libverifproxy/
dist-windows-amd64 \
dist-macos-arm64 \
dist \
eest
eest \
t8n \
t8n_test

ifeq ($(NIM_PARAMS),)
# "variables.mk" was not included, so we update the submodules.
Expand Down
11 changes: 6 additions & 5 deletions docker/dist/entry_point.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ mkdir "${DIST_PATH}/build"
# copy and checksum binaries, copy docs
EXT=""
if [[ "${PLATFORM}" == "windows_amd64" ]]; then
cp -a vendor/nim-rocksdb/build/librocksdb.dll "${DIST_PATH}/build/"
EXT=".exe"
fi

Expand All @@ -230,13 +231,13 @@ done
sed -e "s/GIT_COMMIT/${GIT_COMMIT}/" docker/dist/README.md.tpl > "${DIST_PATH}/README.md"

if [[ "${PLATFORM}" == "linux_amd64" ]]; then
sed -i -e 's/^make dist$/make dist-amd64/' "${DIST_PATH}/README.md"
elif [[ "${PLATFORM}" == "linux_arm64v8" ]]; then
sed -i -e 's/^make dist$/make dist-arm64/' "${DIST_PATH}/README.md"
sed -i -e 's/^make dist$/make dist-linux-amd64/' "${DIST_PATH}/README.md"
elif [[ "${PLATFORM}" == "linux_arm64" ]]; then
sed -i -e 's/^make dist$/make dist-linux-arm64/' "${DIST_PATH}/README.md"
elif [[ "${PLATFORM}" == "windows_amd64" ]]; then
sed -i -e 's/^make dist$/make dist-win64/' "${DIST_PATH}/README.md"
sed -i -e 's/^make dist$/make dist-windows-amd64/' "${DIST_PATH}/README.md"
cp -a docker/dist/README-Windows.md.tpl "${DIST_PATH}/README-Windows.md"
elif [[ "${PLATFORM}" == "macOS_arm64" ]]; then
elif [[ "${PLATFORM}" == "macos_arm64" ]]; then
sed -i -e 's/^make dist$/make dist-macos-arm64/' "${DIST_PATH}/README.md"
fi

Expand Down
Loading