Skip to content

Commit 50c2e14

Browse files
committed
Update manifest PR with small changes from @sbwsg.
1 parent 5599ed6 commit 50c2e14

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

cmd/pullrequest-init/disk.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -175,28 +175,23 @@ func FromDisk(path string) (*PullRequest, map[string]Manifest, error) {
175175
var err error
176176
var manifest Manifest
177177

178-
// Start with comments
179178
pr.Comments, manifest, err = commentsFromDisk(commentsPath)
180179
if err != nil {
181180
return nil, nil, err
182181
}
183182
manifests["comments"] = manifest
184183

185-
// Now Labels
186184
pr.Labels, manifest, err = labelsFromDisk(labelsPath)
187185
if err != nil {
188186
return nil, nil, err
189187
}
190188
manifests["labels"] = manifest
191189

192-
// Now statuses
193190
pr.Statuses, err = statusesFromDisk(statusesPath)
194191
if err != nil {
195192
return nil, nil, err
196193
}
197194

198-
// Finally refs
199-
200195
pr.Base, err = refFromDisk(path, "base.json")
201196
if err != nil {
202197
return nil, nil, err

cmd/pullrequest-init/disk_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ func TestToDisk(t *testing.T) {
146146
}
147147
}
148148
if len(labelManifest) != len(gotManifest) {
149-
t.Errorf("Label manifest does not match expected length. %d != %d, got %+v", len(labelManifest), len(gotManifest), gotManifest)
149+
t.Errorf("Label manifest does not match expected length. expected %d, got %d: %+v", len(labelManifest), len(gotManifest), gotManifest)
150150
}
151151

152152
// Check the comments

cmd/pullrequest-init/fake_github.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ func (g *FakeGitHub) listLabels(w http.ResponseWriter, r *http.Request) {
261261
key, err := prKey(r)
262262
if err != nil {
263263
http.Error(w, err.Error(), http.StatusBadRequest)
264+
return
264265
}
265266

266267
pr, ok := g.pr[key]

0 commit comments

Comments
 (0)