Skip to content

Commit 9cb6201

Browse files
ekexiumti-chi-bot
authored andcommitted
This is an automated cherry-pick of pingcap#53985
Signed-off-by: ti-chi-bot <[email protected]>
1 parent fc70528 commit 9cb6201

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

executor/delete.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,13 +148,18 @@ func (e *DeleteExec) deleteSingleTableByChunk(ctx context.Context) error {
148148
}
149149

150150
func (e *DeleteExec) doBatchDelete(ctx context.Context) error {
151+
<<<<<<< HEAD:executor/delete.go
151152
txn, err := e.ctx.Txn(false)
152153
if err != nil {
153154
return ErrBatchInsertFail.GenWithStack("BatchDelete failed with error: %v", err)
154155
}
155156
e.memTracker.Consume(-int64(txn.Size()))
156157
e.ctx.StmtCommit()
157158
if err := sessiontxn.NewTxnInStmt(ctx, e.ctx); err != nil {
159+
=======
160+
e.Ctx().StmtCommit(ctx)
161+
if err := sessiontxn.NewTxnInStmt(ctx, e.Ctx()); err != nil {
162+
>>>>>>> 9960ae746a3 (executor: do not track membuffer's memory in executor (#53985)):pkg/executor/delete.go
158163
// We should return a special error for batch insert.
159164
return ErrBatchInsertFail.GenWithStack("BatchDelete failed with error: %v", err)
160165
}

executor/insert_common.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -532,13 +532,18 @@ func insertRowsFromSelect(ctx context.Context, base insertCommon) error {
532532
}
533533

534534
func (e *InsertValues) doBatchInsert(ctx context.Context) error {
535+
<<<<<<< HEAD:executor/insert_common.go
535536
txn, err := e.ctx.Txn(false)
536537
if err != nil {
537538
return ErrBatchInsertFail.GenWithStack("BatchInsert failed with error: %v", err)
538539
}
539540
e.memTracker.Consume(-int64(txn.Size()))
540541
e.ctx.StmtCommit()
541542
if err := sessiontxn.NewTxnInStmt(ctx, e.ctx); err != nil {
543+
=======
544+
e.Ctx().StmtCommit(ctx)
545+
if err := sessiontxn.NewTxnInStmt(ctx, e.Ctx()); err != nil {
546+
>>>>>>> 9960ae746a3 (executor: do not track membuffer's memory in executor (#53985)):pkg/executor/insert_common.go
542547
// We should return a special error for batch insert.
543548
return ErrBatchInsertFail.GenWithStack("BatchInsert failed with error: %v", err)
544549
}

executor/replace.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@ func (e *ReplaceExec) exec(ctx context.Context, newRows [][]types.Datum) error {
160160
if err != nil {
161161
return err
162162
}
163-
txnSize := txn.Size()
164163

165164
if e.collectRuntimeStatsEnabled() {
166165
if snapshot := txn.GetSnapshot(); snapshot != nil {
@@ -186,8 +185,12 @@ func (e *ReplaceExec) exec(ctx context.Context, newRows [][]types.Datum) error {
186185
return err
187186
}
188187
}
188+
<<<<<<< HEAD:executor/replace.go
189189
e.memTracker.Consume(int64(txn.Size() - txnSize))
190190
return nil
191+
=======
192+
return txn.MayFlush()
193+
>>>>>>> 9960ae746a3 (executor: do not track membuffer's memory in executor (#53985)):pkg/executor/replace.go
191194
}
192195

193196
// Next implements the Executor Next interface.

0 commit comments

Comments
 (0)