store: key ranges should be sorted in batch cop retry (pingcap#44623) (pingcap#44632)

ti-chi-bot · web-flow · commit 9d4f30dfb350 · 2023-06-16T01:15:09.000Z
close pingcap#44622
diff --git a/store/copr/batch_coprocessor.go b/store/copr/batch_coprocessor.go
@@ -771,6 +771,10 @@ func (b *batchCopIterator) retryBatchCopTask(ctx context.Context, bo *backoff.Ba
 			ranges = append(ranges, *ran)
 		})
 	}
+	// need to make sure the key ranges is sorted
+	sort.Slice(ranges, func(i, j int) bool {
+		return bytes.Compare(ranges[i].StartKey, ranges[j].StartKey) < 0
+	})
 	return buildBatchCopTasks(bo, b.store, NewKeyRanges(ranges), b.req.StoreType, nil, 0, false, 0)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -771,6 +771,10 @@ func (b batchCopIterator) retryBatchCopTask(ctx context.Context, bo backoff.Ba`
`771`	`771`	`ranges = append(ranges, *ran)`
`772`	`772`	`})`
`773`	`773`	`}`
	`774`	`+ // need to make sure the key ranges is sorted`
	`775`	`+ sort.Slice(ranges, func(i, j int) bool {`
	`776`	`+ return bytes.Compare(ranges[i].StartKey, ranges[j].StartKey) < 0`
	`777`	`+ })`
`774`	`778`	`return buildBatchCopTasks(bo, b.store, NewKeyRanges(ranges), b.req.StoreType, nil, 0, false, 0)`
`775`	`779`	`}`
`776`	`780`