Public UpdateTxnSafePointCache again to be used in tests in TiDB (#1732)

 

Signed-off-by: MyonKeminta <[email protected]>

Author: MyonKeminta

tikv/interface.go

@@ -58,6 +58,11 @@ type Storage interface {
 	// GetSafePointKV gets the SafePointKV.
 	GetSafePointKV() SafePointKV
 
+	// UpdateTxnSafePointCache updates the cached txn safe point, which is used for safety check of data access
+	// operations to prevent accessing GC-ed inconsistent data.
+	// WARNING: Exported only for test purpose. Avoid using it when possible.
+	UpdateTxnSafePointCache(txnSafePoint uint64, now time.Time)
+
 	// SetOracle sets the Oracle.
 	SetOracle(oracle oracle.Oracle)
 

tikv/kv.go

@@ -171,9 +171,9 @@ func (s *KVStore) Go(f func()) error {
 	return s.gP.Run(f)
 }
 
-// updateTxnSafePointCache updates the cached txn safe point, which is used for safety check of data access
+// UpdateTxnSafePointCache updates the cached txn safe point, which is used for safety check of data access
 // operations to prevent accessing GC-ed inconsistent data.
-func (s *KVStore) updateTxnSafePointCache(txnSafePoint uint64, now time.Time) {
+func (s *KVStore) UpdateTxnSafePointCache(txnSafePoint uint64, now time.Time) {
 	s.gcStateCacheMu.Lock()
 	defer s.gcStateCacheMu.Unlock()
 
@@ -354,7 +354,7 @@ func NewKVStore(uuid string, pdClient pd.Client, spkv SafePointKV, tikvclient Cl
 	if err != nil {
 		return nil, errors.WithStack(err)
 	}
-	store.updateTxnSafePointCache(txnSafePoint, time.Now())
+	store.UpdateTxnSafePointCache(txnSafePoint, time.Now())
 	store.clientMu.client = client.NewReqCollapse(client.NewInterceptedClient(tikvclient))
 	store.clientMu.client.SetEventListener(regionCache.GetClientEventListener())
 
@@ -418,7 +418,7 @@ func (s *KVStore) runTxnSafePointUpdater() {
 		case now := <-time.After(d):
 			txnSafePoint, err := s.loadTxnSafePoint(context.Background())
 			if err == nil {
-				s.updateTxnSafePointCache(txnSafePoint, now)
+				s.UpdateTxnSafePointCache(txnSafePoint, now)
 				d = pollTxnSafePointInterval
 			} else {
 				d = pollTxnSafePointQuickRepeatInterval

tikv/test_probe.go

@@ -159,7 +159,7 @@ outerLoop:
 }
 
 func (s StoreProbe) UpdateTxnSafePointCache(txnSafePoint uint64, now time.Time) {
-	s.KVStore.updateTxnSafePointCache(txnSafePoint, now)
+	s.KVStore.UpdateTxnSafePointCache(txnSafePoint, now)
 }
 
 func (s StoreProbe) GetGCStatesClient() pdgc.GCStatesClient {