Skip to content

Commit ee9d784

Browse files
[wptrunner] Fix override of TestharnessExecutor.create_test_window() (#54154)
It was `get_or_create_test_window()` prior to 196bcbc. This fixes `wpt run --reuse-window`, which Chromium CI uses to speed up testing.
1 parent b7a53d2 commit ee9d784

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/wptrunner/wptrunner/executors/executorchrome.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ def __init__(self, *args, sanitizer_enabled=False, reuse_window=False, **kwargs)
287287
self.sanitizer_enabled = sanitizer_enabled
288288
self.reuse_window = reuse_window
289289

290-
def get_or_create_test_window(self, protocol):
290+
def create_test_window(self, protocol):
291291
test_window = self.protocol.testharness.persistent_test_window
292292
if test_window:
293293
try:
@@ -303,7 +303,7 @@ def get_or_create_test_window(self, protocol):
303303
protocol.base.set_window(protocol.testharness.runner_handle)
304304
test_window = self.protocol.testharness.persistent_test_window = None
305305
if not test_window:
306-
test_window = super().get_or_create_test_window(protocol)
306+
test_window = super().create_test_window(protocol)
307307
if self.reuse_window:
308308
self.logger.info(f"Created new test window {test_window}")
309309
# Without `--reuse-window`, each testharness test always creates a

0 commit comments

Comments
 (0)