fix(core): handle self-referencing build dependencies (#5177)

* fix(core): handle self-referencing build dependencies

* chore: revert e2e trigger

* fix(core): handle self-referencing virtual workspace build dependencies

Author: merceyz

.yarn/versions/6059c9c1.yml

@@ -0,0 +1,34 @@
+releases:
+  "@yarnpkg/cli": patch
+  "@yarnpkg/core": patch
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-exec"
+  - "@yarnpkg/plugin-file"
+  - "@yarnpkg/plugin-git"
+  - "@yarnpkg/plugin-github"
+  - "@yarnpkg/plugin-http"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-link"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnp"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/extensions"
+  - "@yarnpkg/nm"
+  - "@yarnpkg/pnpify"
+  - "@yarnpkg/sdks"

packages/acceptance-tests/pkg-tests-specs/sources/commands/install.test.js

@@ -444,6 +444,70 @@ describe(`Commands`, () => {
       ),
     );
 
+    test(
+      `should support a self-referencing build dependency`,
+      makeTemporaryEnv(
+        {
+          name: `foo`,
+          dependencies: {
+            'no-deps': `1.0.0`,
+          },
+          scripts: {
+            postinstall: `echo foo`,
+          },
+        },
+        async ({path, run, source}) => {
+          await xfs.writeJsonPromise(ppath.join(path, Filename.rc), {
+            packageExtensions: {
+              'no-deps@*': {
+                dependencies: {
+                  foo: `workspace:*`,
+                },
+              },
+            },
+          });
+
+          await expect(run(`install`, `--inline-builds`)).resolves.toMatchObject({
+            code: 0,
+          });
+        },
+      ),
+    );
+
+    test(
+      `should support a self-referencing virtual workspace build dependency`,
+      makeTemporaryMonorepoEnv(
+        {
+          workspaces: [`packages/*`],
+        },
+        {
+          'packages/foo': {
+            name: `foo`,
+            peerDependencies: {
+              'no-deps': `1.0.0`,
+            },
+            dependencies: {
+              bar: `workspace:*`,
+            },
+            scripts: {
+              postinstall: `echo foo`,
+            },
+          },
+          'packages/bar': {
+            name: `bar`,
+            dependencies: {
+              foo: `workspace:*`,
+            },
+          },
+        },
+        async ({path, run, source}) => {
+          await expect(run(`install`, `--inline-builds`)).resolves.toMatchObject({
+            code: 0,
+          });
+        },
+      ),
+    );
+
     test(
       `it should print a warning when using \`enableScripts: false\``,
       makeTemporaryEnv({

packages/yarnpkg-core/sources/Project.ts

@@ -1328,7 +1328,7 @@ export class Project {
           if (!resolution)
             throw new Error(`Assertion failed: The resolution (${structUtils.prettyDescriptor(this.configuration, dependency)}) should have been registered`);
 
-          if (buildablePackages.has(resolution))
+          if (resolution !== locator.locatorHash && buildablePackages.has(resolution))
             return false;
 
           // Virtual workspaces don't have build scripts but the original might so we need to check it.
@@ -1338,7 +1338,7 @@ export class Project {
 
           const workspace = this.tryWorkspaceByLocator(dependencyPkg);
           if (workspace) {
-            if (buildablePackages.has(workspace.anchoredLocator.locatorHash))
+            if (workspace.anchoredLocator.locatorHash !== locator.locatorHash && buildablePackages.has(workspace.anchoredLocator.locatorHash))
               return false;
 
             hashesToCheck.add(workspace.anchoredLocator.locatorHash);