Fixes global cache (#5739)

**What's the problem this PR addresses?**

The cache fix merged in #5730 had a
bug that caused the global cache to be skipped when a package had no
checksum - which happens when there are no lockfile in the project. This
was detected by the perf regression visible on the dashboard:

<img width="1381" alt="image"
src="https://github.com/yarnpkg/berry/assets/1037931/11aed9d5-7946-418d-806a-6df78aee4734">

**How did you fix it?**

I fixed the condition (it was "use the cache if there's a checksum and
it's compatible", it should have been "use the cache if there's no
checksum, or it's a compatible one") and added tests to avoid further
regressions.

**Checklist**
<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [x] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

Author: arcanis

.yarn/versions/8b4f2cd6.yml

@@ -0,0 +1,34 @@
+releases:
+  "@yarnpkg/cli": patch
+  "@yarnpkg/core": patch
+  "@yarnpkg/plugin-essentials": patch
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-exec"
+  - "@yarnpkg/plugin-file"
+  - "@yarnpkg/plugin-git"
+  - "@yarnpkg/plugin-github"
+  - "@yarnpkg/plugin-http"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-link"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnp"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/extensions"
+  - "@yarnpkg/nm"
+  - "@yarnpkg/pnpify"
+  - "@yarnpkg/sdks"

packages/acceptance-tests/pkg-tests-specs/sources/features/cache.test.ts

@@ -1,4 +1,5 @@
 import {Filename, ppath, xfs} from '@yarnpkg/fslib';
+import {tests}                from 'pkg-tests-core';
 
 describe(`Cache`, () => {
   test(
@@ -12,17 +13,35 @@ describe(`Cache`, () => {
     }),
   );
 
-  test(
-    `it should make packages installable even without network`,
-    makeTemporaryEnv({
-      dependencies: {
-        [`no-deps`]: `1.0.0`,
-      },
-    }, async ({path, run, source}) => {
-      await run(`install`);
-      await run(`install`, {enableNetwork: false});
-    }),
-  );
+  for (const enableGlobalCache of [false, true]) {
+    for (const withLockfile of [false, true]) {
+      test(
+        `it should make packages installable even without network (${enableGlobalCache ? `global` : `local`} cache, ${withLockfile ? `with` : `without`} lockfile)`,
+        makeTemporaryEnv({
+          dependencies: {
+            [`no-deps`]: `1.0.0`,
+          },
+        }, {
+          enableGlobalCache,
+        }, async ({path, run, source}) => {
+          await run(`install`);
+
+          if (!withLockfile)
+            await xfs.removePromise(ppath.join(path, Filename.lockfile));
+
+          const requests = await tests.startRegistryRecording(async () => {
+            await run(`install`);
+          });
+
+          if (withLockfile) {
+            expect(requests).toHaveLength(0);
+          } else {
+            expect(requests.filter(req => req.type !== tests.RequestType.PackageInfo)).toHaveLength(0);
+          }
+        }),
+      );
+    }
+  }
 
   test(
     `it should detect when the files checksum is incorrect`,

packages/plugin-essentials/sources/commands/info.ts

@@ -255,18 +255,13 @@ export default class InfoCommand extends BaseCommand {
         if (!extra.has(`cache`))
           return;
 
-        const cacheOptions = {
-          mockedPackages: project.disabledLocators,
-          unstablePackages: project.conditionalLocators,
-        };
-
         const checksum = project.storedChecksums.get(pkg.locatorHash) ?? null;
-        const cachePath = cache.getLocatorPath(pkg, checksum, cacheOptions);
+        const cachePath = cache.getLocatorPath(pkg, checksum);
 
         let stat;
         if (cachePath !== null) {
           try {
-            stat = xfs.statSync(cachePath);
+            stat = await xfs.statPromise(cachePath);
           } catch {}
         }
 

packages/yarnpkg-core/sources/Cache.ts

@@ -176,7 +176,7 @@ export class Cache {
     return true;
   }
 
-  getLocatorPath(locator: Locator, expectedChecksum: string | null, opts: CacheOptions = {}) {
+  getLocatorPath(locator: Locator, expectedChecksum: string | null) {
     // When using the global cache we want the archives to be named as per
     // the cache key rather than the hash, as otherwise we wouldn't be able
     // to find them if we didn't have the hash (which is the case when adding
@@ -365,7 +365,7 @@ export class Cache {
         isColdHit: true,
       });
 
-      const cachePath = this.getLocatorPath(locator, checksum, opts);
+      const cachePath = this.getLocatorPath(locator, checksum);
       const copyProcess: Array<() => Promise<void>> = [];
 
       // Copy the package into the mirror
@@ -403,8 +403,8 @@ export class Cache {
       const mutexedLoad = async () => {
         const isUnstablePackage = opts.unstablePackages?.has(locator.locatorHash);
 
-        const tentativeCachePath = isUnstablePackage || expectedChecksum && this.isChecksumCompatible(expectedChecksum)
-          ? this.getLocatorPath(locator, expectedChecksum, opts)
+        const tentativeCachePath = isUnstablePackage || !expectedChecksum || this.isChecksumCompatible(expectedChecksum)
+          ? this.getLocatorPath(locator, expectedChecksum)
           : null;
 
         const cacheFileExists = tentativeCachePath !== null

packages/yarnpkg-core/sources/Project.ts

@@ -1136,10 +1136,10 @@ export class Project {
         const locator = this.storedPackages.get(locatorHash);
         const checksum = this.storedChecksums.get(locatorHash) ?? null;
 
-        const p = cache.getLocatorPath(locator!, checksum, cacheOptions);
-        const stat = p ? await xfs.statPromise(p) : null;
+        const p = cache.getLocatorPath(locator!, checksum);
+        const stat = await xfs.statPromise(p);
 
-        return stat?.size ?? 0;
+        return stat.size;
       }));
 
       const finalSizeChange = addedSizes.reduce((sum, size) => sum + size, 0) - (cleanInfo?.size ?? 0);