Skip to content

Commit c00daf4

Browse files
arcanismerceyz
authored andcommitted
Fixes the iarna test (#5794)
**What's the problem this PR addresses?** One of our tests on the `@types` auto-add was testing `@iarna/toml`, but this package actually contains types (but was reported as not having them due to a bug on Algolia's side). **How did you fix it?** I changed the package to `@babel/parser`, which doesn't have builtin types. **Checklist** <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed. (cherry picked from commit 3e2dfb2)
1 parent a39f3e1 commit c00daf4

File tree

8 files changed

+15
-11
lines changed

8 files changed

+15
-11
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"name": "@babel/parser",
3+
"version": "7.23.0"
4+
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"name": "@babel/traverse",
3+
"version": "7.99.0"
4+
}

packages/acceptance-tests/pkg-tests-fixtures/packages/@iarna__toml-1.0.0/package.json

Lines changed: 0 additions & 4 deletions
This file was deleted.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"name": "@types/babel__traverse",
3+
"version": "7.99.0"
4+
}

packages/acceptance-tests/pkg-tests-fixtures/packages/@types__iarna__toml-1.0.0/package.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

packages/acceptance-tests/pkg-tests-specs/sources/plugins/plugin-typescript.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,14 @@ describe(`Plugins`, () => {
4444
`it should automatically add @types for scoped packages`,
4545
makeTemporaryEnv({}, async ({path, run, source}) => {
4646
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});
47-
await run(`add`, `@iarna/toml`);
47+
await run(`add`, `@babel/[email protected]`);
4848

4949
await expect(readManifest(path)).resolves.toMatchObject({
5050
dependencies: {
51-
[`@iarna/toml`]: `^1.0.0`,
51+
[`@babel/traverse`]: `7.99.0`,
5252
},
5353
devDependencies: {
54-
[`@types/iarna__toml`]: `^1`,
54+
[`@types/babel__traverse`]: `^7`,
5555
},
5656
});
5757
}),

0 commit comments

Comments
 (0)