feat(fslib): add fchown support (#4801)

Author: jj811208

.pnp.cjs

@@ -0,0 +1,36 @@
+releases:
+  "@yarnpkg/cli": patch
+  "@yarnpkg/fslib": minor
+  "@yarnpkg/pnp": patch
+  "@yarnpkg/pnpify": patch
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-exec"
+  - "@yarnpkg/plugin-file"
+  - "@yarnpkg/plugin-git"
+  - "@yarnpkg/plugin-github"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-link"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnp"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - vscode-zipfs
+  - "@yarnpkg/builder"
+  - "@yarnpkg/core"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/nm"
+  - "@yarnpkg/sdks"
+  - "@yarnpkg/shell"

.yarn/versions/62ea7f20.yml

@@ -8,6 +8,12 @@ Yarn now accepts sponsorships! Please give a look at our [OpenCollective](https:
 
 ## Master
 
+## 3.2.4
+
+### Compatibility
+
+- The patched filesystem now supports `fchown`.
+
 ## 3.2.3
 
 ### Bugfixes

CHANGELOG.md

@@ -216,6 +216,9 @@ export abstract class FakeFS<P extends Path> {
   abstract fchmodPromise(fd: number, mask: number): Promise<void>;
   abstract fchmodSync(fd: number, mask: number): void;
 
+  abstract fchownPromise(fd: number, uid: number, gid: number): Promise<void>;
+  abstract fchownSync(fd: number, uid: number, gid: number): void;
+
   abstract chownPromise(p: P, uid: number, gid: number): Promise<void>;
   abstract chownSync(p: P, uid: number, gid: number): void;
 

packages/yarnpkg-core/sources/worker-zip/index.js

@@ -142,6 +142,14 @@ export class NoFS extends FakeFS<PortablePath> {
     throw makeError();
   }
 
+  async fchownPromise(): Promise<never> {
+    throw makeError();
+  }
+
+  fchownSync(): never {
+    throw makeError();
+  }
+
   async chownPromise(): Promise<never> {
     throw makeError();
   }

packages/yarnpkg-fslib/sources/FakeFS.ts

@@ -262,6 +262,16 @@ export class NodeFS extends BasePortableFakeFS {
     return this.realFs.chmodSync(npath.fromPortablePath(p), mask);
   }
 
+  async fchownPromise(fd: number, uid: number, gid: number): Promise<void> {
+    return await new Promise<void>((resolve, reject) => {
+      this.realFs.fchown(fd, uid, gid, this.makeCallback(resolve, reject));
+    });
+  }
+
+  fchownSync(fd: number, uid: number, gid: number): void {
+    return this.realFs.fchownSync(fd, uid, gid);
+  }
+
   async chownPromise(p: PortablePath, uid: number, gid: number) {
     return await new Promise<void>((resolve, reject) => {
       this.realFs.chown(npath.fromPortablePath(p), uid, gid, this.makeCallback(resolve, reject));

packages/yarnpkg-fslib/sources/NoFS.ts

@@ -182,6 +182,14 @@ export abstract class ProxiedFS<P extends Path, IP extends Path> extends FakeFS<
     return this.baseFs.chmodSync(this.mapToBase(p), mask);
   }
 
+  async fchownPromise(fd: number, uid: number, gid: number): Promise<void> {
+    return this.baseFs.fchownPromise(fd, uid, gid);
+  }
+
+  fchownSync(fd: number, uid: number, gid: number): void {
+    return this.baseFs.fchownSync(fd, uid, gid);
+  }
+
   async chownPromise(p: P, uid: number, gid: number) {
     return this.baseFs.chownPromise(this.mapToBase(p), uid, gid);
   }

packages/yarnpkg-fslib/sources/NodeFS.ts

@@ -1060,6 +1060,14 @@ export class ZipFS extends BasePortableFakeFS {
     }
   }
 
+  async fchownPromise(fd: number, uid: number, gid: number): Promise<void> {
+    return this.chownPromise(this.fdToPath(fd, `fchown`), uid, gid);
+  }
+
+  fchownSync(fd: number, uid: number, gid: number): void {
+    return this.chownSync(this.fdToPath(fd, `fchownSync`), uid, gid);
+  }
+
   async chownPromise(p: PortablePath, uid: number, gid: number) {
     return this.chownSync(p, uid, gid);
   }

packages/yarnpkg-fslib/sources/ProxiedFS.ts

@@ -516,6 +516,30 @@ export class ZipOpenFS extends BasePortableFakeFS {
     });
   }
 
+  async fchownPromise(fd: number, uid: number, gid: number): Promise<void> {
+    if ((fd & ZIP_MASK) !== ZIP_MAGIC)
+      return this.baseFs.fchownPromise(fd, uid, gid);
+
+    const entry = this.fdMap.get(fd);
+    if (typeof entry === `undefined`)
+      throw errors.EBADF(`fchown`);
+
+    const [zipFs, realFd] = entry;
+    return zipFs.fchownPromise(realFd, uid, gid);
+  }
+
+  fchownSync(fd: number, uid: number, gid: number): void {
+    if ((fd & ZIP_MASK) !== ZIP_MAGIC)
+      return this.baseFs.fchownSync(fd, uid, gid);
+
+    const entry = this.fdMap.get(fd);
+    if (typeof entry === `undefined`)
+      throw errors.EBADF(`fchownSync`);
+
+    const [zipFs, realFd] = entry;
+    return zipFs.fchownSync(realFd, uid, gid);
+  }
+
   async chownPromise(p: PortablePath, uid: number, gid: number) {
     return await this.makeCallPromise(p, async () => {
       return await this.baseFs.chownPromise(p, uid, gid);