Skip to content

Commit 4a8e0b4

Browse files
ysravankumarPhilJayvpopdanielgindimikedream89
authored
update (#1)
* Extend test cases (for bugfix) * Remove unused local variable * Removed redundancies * Fixed entry searching algorithm to handle sequential same values * Move on from the deprecated property in the demos * Avoid crash for `centerAxisLabelsEnabled` when entry count == 1 * Fixes for cubic bezier edges * Removed redundant condition * Update gradle * Guard `roundToNextSignificant` and `decimal` from invalids * Minor fixes for interval in axis labels * Allow label centering for 1 label * Set z-index of markers to be the highest * [FIX] not find centeringEnabled * Extend test cases * Refactoring, prepare example for testing highlight * Fix typo * Corrected calcMinMaxY for autoScaleMinMax * Feature: spaceMin/spaceMax for axis * Default spaceMin/spaceMax for bar charts This avoids having to set custom axisMinimum/axisMaximum, or offsetting x * Improved highlight for scatter/bubble, and fixes highlightValueWithX * Avoid crash when dataset is empty * Update gradle & android sdk * Default spaceMin/max for xAxis in candlestick charts * Fixed last label of line chart not rendering * Fixed bar chart demo first value being empty * Clear up grouped bar example * Make highlightFullBarEnabled feature work again * Update README.md * Update README.md * Update README.md * Move to Realm v2.0.2, update example * Migrate to Realm v2.0.2, fix example * Update AxisBase.java Mistake fixed * Make automatically disabling slice-spacing an opt-in feature * Bugfix: Corrected clipRect on the proper rect variable * Fixed glitch in clipping rects. It's the Android's renderer's bug. When specifying exact clipping rects, they are clipping more than they should! So drawing a thin 1px line on the edge of a clipping rect fail. Instead of insetting by half the line width, inset by full line width. * Renamed new property getter * Added `clipValuesToContent` property for clipping values * Added missing isDrawBordersEnabled getter * Fixed weird glitch in mixed (pos/neg) stacked bars highlight ChartsOrg/Charts#1744 ChartsOrg/Charts#1726 * Fixed double calculation of xAxis spacing * Fix: typo for October * Gradle updates * Fixed EPSILON. (Closes PhilJay#2432) Closes PhilJay#2424 Closes PhilJay#2394 Closes PhilJay#2393 Closes PhilJay#2385 * Added IndexAxisValueFormatter, to allow for easy x-axis labels like MPAndroidChart 2.0 * Fixed a bug where the mod-360 bypass draws a full-circle for 0 slices. * Upgrade version * Upgrade manifest * Update README.md * Update README.md * Update README.md * drawBottomYLabelEntryEnabled * Gradle updates * resetZoom() * Correctly position 0 in stacked bar * Fix for default text size being set in PX instead of DP The default text size in ComponentBase was defined as 10 pixels instead of 10dp, which causes tiny text and does not reflect the javadoc and the general behavior of setTextSize(...) * Fix circles inherit alpha (Fixes PhilJay#2620) ISSUE: When using multiple LineDataSets like the follows: int solidColor = 0xFFFF00FF; dataSet.setColor(solidColor); dataSet.setCircleColor(solidColor); int semiTransparentColor = 0x8A000000; fadedSet.setColor(semiTransparentColor); LineData data = new LineData(dataSet, fadedSet); the circles in 'dataSet' will rendered with the alpha from fadedSet (0x8A). The reason for this is that mRenderPaint is not reset properly before drawing the circles. The first time drawCircles is called the imageCache.fill(...) method is used where the color is set by mRenderPaint.setColor(set.getCircleColor(i)), restoring the alpha to 0xFF. The second time homever, imageCache.fill(...) is not called which means that mRenderPaint will use it's old color/alpha, which in this case is from fadedSet. TEST INFO: To trigger the issue, add the following to LineChartActivity1: final ArrayList<Entry> fadedEntries = new ArrayList<>(); for (int i = 0; i < count; i++) { float val = (float) (Math.random() * range) + 3; fadedEntries.add(new Entry(i, val)); } final LineDataSet fadedDateSet = new LineDataSet(fadedEntries, "Faded"); fadedDateSet.setColor(0x42000000); dataSets.add(fadedDateSet); // add the datasets and launch the first item in the example app. SOLUTION: This commit replaces mRenderPaint with null when drawing the circle bitmap. If circleColor has been defined with a semi-transparent color, it will be drawn that way in the cached bitmap, hence the the bitmap itself does not need to be drawn with an alpha. * fix tests for java executable location. bug PhilJay#2805 PhilJay#2805 * fix PhilJay#2813 * Implemented icon support * Added examples for icon entries * Improved feb29 formula * Moved auto scale before render of axis lines ChartsOrg/Charts#2177 * Consider isEnabled in more axis rendering cases * Fix for missing setters in getInstance method The zoomAndCenterAnimated method in BarLineChartBase crashes with a NullPointer exception because the yAxis variable is null when onAnimationUpdate is called. The yAxis is null because of missing setters in the getInstance method of AnimatedZoomJob. * Update README.md * Update README.md * Update README.md * Updating versions * Remove line width minimum constraint * Update README.md * Update README.md * Update README.md * Clear lastHighlighted when `clear` is called * Create LICENSE * Fix some potential NPEs with WeakReference usage Even if the WeakReference field is not null, the contained value may be null. Additionally, you always need a strong reference to the value to ensure it isn't garbage collected while you're using it. * Update README.md * Update README.md * Run view port jobs after applying changes * Add default x spacing (half width) for scatter chart as well * Fix CombinedChartView not drawing markers * Allow locking drag on either axes * add option to draw limit lines on top of data * Refactored LargeValueFormatter * Update README.md * Update gradle and dependencies * Out comment gradle wrapper * Update maven android plugin * Add maven plugin to example * Add new google repo * Add new google repo * Update README.md * Update version * Update README.md * Update README.md * Added option to set restrictions for Y axis autoscaling. * Update gitignore, add assets * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Add files via upload * Delete googlee1205ea43aa2c32a.html * Avoid that the last label entry in the x-labels clip off the edge of the screen PhilJay#3819 * Add option for using slice color as value line color Fixes: PhilJay#3897 * Rename RadarChartActivitry to RadarChartActivity * Remove unused imports * Remove Custom Check calculate() no longer checks if min and max is custom, it just adds the padding. * update to Android Studio 3.1.2 * Create ISSUE_TEMPLATE.md * Create PULL_REQUEST_TEMPLATE.md * refactor(EasingFunction): Simplified EasingFunction EasingFunction has been simplified greatly, and I've added a MUCH needed annotation to relevant methods. Easing.EasingOptions has been deprecated, as well as any methods using them. Converting is as simple as deleting the "EasingOptions" part. A new signature is available for animateXY()! You are now able to pass one EasingFunction to animateXY() if you want both axes to be animated the same way. Quietly included are some gradle build updates, incrementing the appcompat version to 27.1.1, and using the new `javacompiler` to avoid deprecation of `javacompile` * fix(docs): Broken Contributing link * Update issue templates * Downgrade ISSUE_TEMPLATE.md to generic issue * Update Bug_report.md quick fix * Update CONTRIBUTING.md Condensed CONTRIBUTING and added helpful reference links. And cake! * Update README.md * Delete lingering MyEasingFunction.java I made the decision to remove this file instead of updating it, as I'm sure most will instead prefer to look at the actual Easing class. If you miss this example class... ¯\_(ツ)_/¯ * - multiple gradient color * docs(templates): Update Issue & PR templates I've updated the issue and pull request templates, again. This time I looked to the node.js request library for inspiration. It's no secret that this project has been attracting a LOT of very low-quality issues. Almost all are asking questions that can be easily answered if the person looked at the example project or the wiki. Specifically, the new Support_help.md file. This file will hopefully bait these low-quality support questions and reduce the number of opened issues regarding debugging or support significantly. I've updated the default ISSUE_TEMPLATE.md to be a copy of Bug_report.md to force people to read that notice text if they decide to not choose any of the templates. * chore(template): Move templates to .github folder * Update and reorganise copy data sets methods (Fix for PhilJay#1604). Copying class properties is always done in protected copy method. * Fixed code review comments. * Remove mLabelRotatedHeight counted twice, when calculating legend offsets. (Fix for PhilJay#2369). Removed statements where completely not needed as calculating offsets is alredy done in BarLineCharBase#calculateOffsets(...) * Fixed Javadoc * Remove redundant findViewById casts, that became obsolete after migration to API 26. * docs(README): Update & simplify README - Re-ordered some of the sections - Simplified some sections - Reformatted here and there - Added a few emojis, how cute! The goal of this change was to hopefully further reduce the amount of issue support/ question spam. By moving the sections around to show the more important parts higher up, like usage and documentation links, I hope this will make it easier for people to find the documentation. * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Huge Project Refresh Before anyone freaks out, all these changes are under-the-hood, meaning that you probably won't even notice them at all. The biggest difference is raising the minSdkVersion from 9 to 14. Recently android bumped this number interally as there are basically no devices running lower than 14 anymore. Sorry but you are just wasting your time if you are trying to support anything lower than 14 now. The next biggest change is updating the project to the new AndroidX libraries, which changes some imports and nothing else really. The third biggest change is fixing a few bugs in the code that cause values to be drawn even if there are none, which results in your app crashing. Surprisingly, these checks already existed in a few of the newer chart types, but most lacked this simple check. Other than those three changes, nothing else is functionally different. Well, saving to gallery works on all charts in the example app now, and you can quickly see the code for each example in the menus. The only real potential "breaking" change is that charts are now saved as PNGs by default instead of JPGs if you go the route of not specifying as a JPG. You may want to double check your file sizes as PNGs can be larger than low quality JPGs. I still have more plans for simplifying the API and fixing other issues with the project, for the small few that closely pay attention to individual commits: there's going to be more soon. * More Linting Lots of things in the example app are now marked with the 'final' modifier, and saveToGallery() is protected in classes that implement it. As well, new suppressions are in a few places. NEW text is now removed completely. Looks like this has been unused for a long time and it's just stuck around anyway. * More Cleanup I've removed the realm examples, mainly because the library was buggy. In the previous commit, I already removed the examples from the list since they didn't add anything to the overall demonstration. I thought that if anyone wants to use realm.io with the charts, they can see the actual library. The file structure has been updated to match how Android Studio does things. Some files added way back when have been deleted as they don't do anything but cause the linter to freak out about 'unused properties' All 'build.gradle' files have been refreshed as well. Small addition to the README file to add a quick way to reach sections of the page. * Bump version to 3.1.0-alpha * Fix link error * New ValueFormatter I created a simplified value formatter class, which is an abstract class rather than an interface. The switch was chosen because the new format has all the methods predefined (something an interface wouldn't allow) meaning you can extend it and only change what you want. This also means that you only need one value formatting class for labels rather than two different classes, it just makes more sense. Please check the method signatures to learn how to use them, I'm sure you'll find this new format is much more customizable and faster to use. I've made the class abstract even though there are no abstract methods or fields, this is because it would certainly be a mistake to create a ValueFormatter and not override any methods. To convert existing code, just use 'extends' instead of 'implements' and change the names to 'ValueFormatter'. You'll need to change the methods you overwrite as well, just check the class and use the one you need. * Remove Deprecated Things Long deprecated Legend constructor and positioning has been removed, it was replaced with a new way to position the Legend. The old Easing options have been removed now, accessing them is as easy as removing the `EasingOption` part, such that the names look like `Easing.Linear` or `Easing.EaseInOutQuad` now. * Remove unnecessary API checks Also added run configuration for the MPChartExample. Removed deprecated Legend stuff. * Add Curved Slices to Pie Chart Finally added support for rounded slices, and somewhat improved the code for the PieChartRenderer class. * Add option to set minimum angles Allows to force minimum slice angles when drawing charts, which means that any slices with angles lower than the minimum will be drawn with the minimum angle. When changing this setting on the fly, you have to call `notifyDataSetChanged()` and `invalidate()` for the minimum angle to take effect. This only functions if all slices can be drawn with the minimum angle. For example if a chart has 5 slices, the largest functioning minimum angle is `72f` degrees on a 360 degree chart, or 20% of the chart's `maxAngle`. * Update README.md * Update Bug_report.md * Update Feature_request.md * Update Support_help.md * Minor changes to project and example * New example app release * Update README.md * Update README.md * Update README.md * Update README.md * PercentFormatter: make space between number and percent sign optional * fix little typo * Update gradle * Create FUNDING.yml * Update FUNDING.yml * Update README.md * Safe guards These will be even more important when moving to Kotlin ranges * Added highlightColor parameter for pie charts ChartsOrg/Charts#2961 * Consider axis dependency in Combined chart ChartsOrg/Charts#2874 * Added an implementation of Douglas Peucker with resultCount input ChartsOrg/Charts#2848 * Fixed axis label disappearing when zooming in ChartsOrg/Charts#3132 * Make min/max axis labels configurable ChartsOrg/Charts#2894 * Avoid race condition for interval/intervalMagnitude ChartsOrg/Charts#2377 * Custom text alignment for no-data ChartsOrg/Charts#3199 * Select correct axis for legend distance calculation in horz bar chart ChartsOrg/Charts#2214 * Use correct color index for bubble chart ChartsOrg/Charts#3202 * Added dataIndex param for highlightValue (combined charts) ChartsOrg/Charts#2852 * Reset min/max when clearing ChartDataSet ChartsOrg/Charts#3265 * Call notifyDataChanged for an opportunity for subclasses * Add a warning message if pie chart has more than one data set ChartsOrg/Charts#3286 * Add option to disable clipping data to contentRect ChartsOrg/Charts#3360 * Support for labelXOffset for YAxis label * This is for the inline bubble selection ChartsOrg/Charts#3548 * Fixed index out of bounds issue when using stacked bar chart ChartsOrg/Charts@b03cf16 * Improve min/max calculation ChartsOrg/Charts#3650 * Call onChartScale listener after double-tap-zoom ChartsOrg/Charts#3770 * Multiple colors for valueline ChartsOrg/Charts#3709 * Renamed values -> entries for consistency ChartsOrg/Charts#3847 * Improved negative offset for horz bar chart ChartsOrg/Charts#3854 * maxHeight didn't account for the last label ChartsOrg/Charts#3900 * Fixed a bug where a pie slice without highlight enabled is hidden ChartsOrg/Charts#3969 * Remove unexpected dash line during linear animation ChartsOrg/Charts#4094 * Corrected check for line in vertical bounds ChartsOrg/Charts#4100 * Finalized vertical line collision check * Fixed merge residue * Implement a more generic Fill class instead of GradientColor Support HorizontalBarChart too. * Update LICENSE The LICENSE file was not properly filled out. It was missing some templates that were supposed to be filled in at the end of the license. Additionally, the entire Apache 2.0 license is not required on a project that makes use of it. Only this disclaimer is required. See http://www.apache.org/licenses/LICENSE-2.0#apply under the "How to apply the Apache License to your work" for more information. * fix NPE when use solid color with barchart * Update BarChartRenderer.java * Update HorizontalBarChartRenderer.java * Update BarChartRenderer.java * Update README.md * Update README.md * Update README.md * Update LICENSE * Revert: e5b6619 - bring back polymorphism to value formatters If anyone does not know how to add a space or change the format in anyway, please learn how to subclass. * Update README.md * Update README.md Co-authored-by: PhilJay <[email protected]> Co-authored-by: Voicu <[email protected]> Co-authored-by: Daniel Cohen Gindi <[email protected]> Co-authored-by: Mark <[email protected]> Co-authored-by: nielsz <[email protected]> Co-authored-by: Evgeniy <[email protected]> Co-authored-by: Mahesh Gaya <[email protected]> Co-authored-by: Patrick Ivarsson <[email protected]> Co-authored-by: travisfw <none@none> Co-authored-by: Stephen McBride <[email protected]> Co-authored-by: Scott Kennedy <[email protected]> Co-authored-by: davidgoli <[email protected]> Co-authored-by: Maxim Pestryakov <[email protected]> Co-authored-by: Pawel Grzybek <[email protected]> Co-authored-by: zhanglong <[email protected]> Co-authored-by: sembozdemir <[email protected]> Co-authored-by: Wilder Pereira <[email protected]> Co-authored-by: almic <[email protected]> Co-authored-by: Hannes Achleitner <[email protected]> Co-authored-by: Anirut Teerabut <[email protected]> Co-authored-by: RobertZagorski <[email protected]> Co-authored-by: duchampdev <[email protected]> Co-authored-by: Nathan Fiscaletti <[email protected]> Co-authored-by: Anirut Teerabut <[email protected]>
1 parent 8f4432c commit 4a8e0b4

File tree

490 files changed

+28862
-23725
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

490 files changed

+28862
-23725
lines changed

.github/FUNDING.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# These are supported funding model platforms
2+
3+
github: # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2]
4+
patreon: mpandroidchart
5+
open_collective: philippjahoda
6+
ko_fi: # Replace with a single Ko-fi username
7+
tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
8+
community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
9+
liberapay: # Replace with a single Liberapay username
10+
issuehunt: # Replace with a single IssueHunt username
11+
otechie: # Replace with a single Otechie username
12+
custom: # Replace with up to 4 custom sponsorship URLs e.g., ['link1', 'link2']

.github/ISSUE_TEMPLATE.md

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
<!---
2+
BEFORE YOU SUBMIT please read the following:
3+
4+
Please search open/closed issues before submitting since someone might have asked
5+
the same thing before!
6+
7+
If you have a support request or question please submit them on StackOverflow:
8+
https://stackoverflow.com/questions/tagged/mpandroidchart
9+
using the tags `android` & `mpandroidchart`
10+
11+
Please also look at the CONTRIBUTING file before opening an issue:
12+
https://github.com/PhilJay/MPAndroidChart/blob/master/CONTRIBUTING.md
13+
14+
Issues on GitHub are only related to problems with MPAndroidChart itself and we
15+
cannot answer support questions here. We will close your issue without a response.
16+
-->
17+
18+
**Summary**
19+
<!-- A clear and concise description of what the bug is. -->
20+
21+
**Expected Behavior**
22+
<!-- A clear and concise description of what you expected to happen. -->
23+
24+
**Possible Solution**
25+
<!-- Not required, but suggest a fix/ reason for the bug, -->
26+
<!-- or ideas how to implement the addition or change -->
27+
28+
**Device (please complete the following information):**
29+
- Device: [e.g. Google Pixel]
30+
- Android Version [e.g. 7.0]
31+
- Library Version (e.g. 3.1.0-alpha)
32+
33+
**Additional Context**
34+
<!-- Add any other context about the problem here.
35+
If you have source code demonstrating this bug, create a Gist:
36+
https://help.github.com/articles/creating-gists/
37+
and link to it here. -->
Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
---
2+
name: Bugs
3+
about: Create a bug report to help us improve
4+
5+
---
6+
7+
<!---
8+
BEFORE YOU SUBMIT please read the following:
9+
10+
Please search open/closed issues before submitting since someone might have asked the same thing before!
11+
12+
If you have a support request or question please submit them on StackOverflow:
13+
https://stackoverflow.com/questions/tagged/mpandroidchart
14+
using the tags `android` & `mpandroidchart`
15+
16+
Please also look at the CONTRIBUTING file before opening an issue:
17+
https://github.com/PhilJay/MPAndroidChart/blob/master/CONTRIBUTING.md
18+
19+
Issues on GitHub are only related to problems with MPAndroidChart itself and we cannot answer
20+
support questions here. We will close your issue without a response.
21+
-->
22+
23+
**Summary**
24+
<!-- A clear and concise description of what the bug is. -->
25+
26+
**Expected Behavior**
27+
<!-- A clear and concise description of what you expected to happen. -->
28+
29+
**Possible Solution**
30+
<!-- Not required, but suggest a fix/ reason for the bug, -->
31+
<!-- or ideas how to implement the addition or change -->
32+
33+
**Device (please complete the following information):**
34+
- Device: [e.g. Google Pixel]
35+
- Android Version [e.g. 7.0]
36+
- Library Version (e.g. 3.1.0-alpha)
37+
38+
**Additional Context**
39+
<!-- Add any other context about the problem here.
40+
If you have source code demonstrating this bug, create a Gist:
41+
https://help.github.com/articles/creating-gists/
42+
and link to it here. -->
43+
44+
ADD A REWARD using [Speed](speedoss.com) to SOLVE this issue QUICKLY and SUPPORT this project.
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
---
2+
name: Feature Request
3+
about: Suggest an idea for this project
4+
5+
---
6+
7+
<!---
8+
BEFORE YOU SUBMIT please read the following:
9+
10+
Please search open/closed issues before submitting since someone might have asked the same thing before!
11+
12+
If you have a support request or question please submit them on StackOverflow:
13+
https://stackoverflow.com/questions/tagged/mpandroidchart
14+
using the tags `android` & `mpandroidchart`
15+
16+
Please also look at the CONTRIBUTING file before opening an issue:
17+
https://github.com/PhilJay/MPAndroidChart/blob/master/CONTRIBUTING.md
18+
19+
Issues on GitHub are only related to problems with MPAndroidChart itself and we cannot answer
20+
support questions here. We will close your issue without a response.
21+
-->
22+
23+
**Is your feature request related to a problem? Please describe.**
24+
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
25+
26+
**Describe the solution you'd like**
27+
<!-- A clear and concise description of what you want to happen. -->
28+
29+
**Describe alternatives you've considered**
30+
<!-- A clear and concise description of any alternative solutions or features you've considered. -->
31+
32+
**Additional context**
33+
<!-- Add any other context or screenshots about the feature request here. -->
34+
ADD A REWARD using [Speed](speedoss.com) to SOLVE this issue QUICKLY and SUPPORT this project.
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
---
2+
name: Support
3+
about: I need help!
4+
5+
---
6+
7+
# *STOP RIGHT THERE!*
8+
9+
Issues are ***NOT*** for getting help, only for reporting bugs and feature requests.
10+
11+
Search open and closed issues to see if your question already has an answer. However, **do not create a new issue.**
12+
13+
Instead, do the following:
14+
15+
1. Download the [Example App](https://play.google.com/store/apps/details?id=com.xxmassdeveloper.mpchartexample) and check out the [source code](https://github.com/PhilJay/MPAndroidChart/tree/master/MPChartExample/src/com/xxmassdeveloper/mpchartexample). 90% of the time there is an example that does exactly what you are trying to do.
16+
17+
1. Look at the [Wiki](https://github.com/PhilJay/MPAndroidChart/wiki) for the official documentation for MPAndroidChart. You can also browse the [javadoc](https://jitpack.io/com/github/philjay/mpandroidchart/v3.1.0-alpha/javadoc/) for a more detailed tutorial of the API.
18+
19+
1. Go to [StackOverflow](https://stackoverflow.com/questions/tagged/mpandroidchart) and ask your questions there. The community will be much more helpful and willing to offer guidance.
20+
21+
22+
### You have been warned!
23+
24+
From now on, any issues asking for help will get closed with a link to this file.
25+
26+
### Additional Context
27+
ADD A REWARD using [Speed](speedoss.com) to SOLVE this issue QUICKLY and SUPPORT this project.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
## PR Checklist:
2+
- [ ] I have tested this extensively and it does not break any existing behavior.
3+
- [ ] I have added/updated examples and tests for any new behavior.
4+
- [ ] If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]
5+
<!-- If you'd like to suggest a significant change, please
6+
create an issue to discuss those changes and gather
7+
feedback BEFORE submitting your PR. -->
8+
9+
10+
## PR Description
11+
<!-- Describe Your PR Here! -->
12+
13+
<!-- What does this add/ remove/ fix/ change? -->
14+
15+
<!-- WHY should this PR be merged into the main library? -->

.gitignore

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@
1111
# generated files
1212
bin/
1313
gen/
14+
generated/
15+
docs/
16+
finalOutput/
17+
projectFilesBackup/
18+
19+
build.xml
1420

1521
# Local configuration file (sdk path, etc)
1622
local.properties
@@ -37,3 +43,5 @@ build/
3743

3844
# maven
3945
target/
46+
47+
.DS_Store

.idea/runConfigurations/MPChartExample.xml

Lines changed: 52 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.settings/gradle/org.springsource.ide.eclipse.gradle.core.prefs

Lines changed: 0 additions & 4 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
> ### Notice
2+
> *Before you continue, this is the* **ANDROID** *library. If you have an* **iOS** *device, please go here instead*:
3+
>
4+
> https://github.com/danielgindi/Charts
5+
>
6+
> They might tell you to come back here, if they do, listen to them and ignore this notice.
7+
8+
# How to contribute
9+
10+
Bug-fixes and features often come from users of the MPAndroidChart library and improve it greatly. We want to keep it as easy as possible to contribute changes that improve the experience for users all around the world. There are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
11+
12+
## Creating Issues
13+
14+
There are two main issue templates, one for bugs and another for feature requests. Please use them! You're issue will be much easier to understand, and bugs easier to fix, if you follow the templates. If your issue doesn't fit into those, just use the generic template.
15+
16+
Search existing [issues] to see if your bug has already been reported or if a feature request already exists. Don't forget to remove `is:open` so you see all the issues! If you find that one already exists, use reactions to show how much you care!
17+
18+
## Making Pull Requests
19+
20+
Careful! If you fail to follow these guidlines, you're pull request may be closed, *even if it's really awesome*.
21+
22+
0. **Search** open [pull requests] AND existing [issues] to make sure what you want to do isn't already being worked on or already has an open pull request.
23+
1. **Fork** the repository
24+
1. **Create** a new branch based on `master`, and name it according to your changes
25+
1. **Add** your commits, they MUST follow the [Commit Style](#commit-style) below
26+
1. **Test** your changes by actually running the example app, or create a new example
27+
1. **Create** a pull request, following the auto-generated template
28+
1. ???
29+
1. Profit :money_with_wings:
30+
31+
You are encouraged to use [GitHub Desktop] to inspect your code changes before committing them. It can reveal small changes that might have gone unnoticed, and would be requested for removal before merging.
32+
33+
Check out [#3975](https://github.com/PhilJay/MPAndroidChart/pull/3975) for an example of a good-made-better pull request.
34+
35+
## Commit Style
36+
37+
* **Make commits of logical units**
38+
Don't load your commits with tons of changes, this makes it hard to follow what is happening. However, if you have done a lot of work, and there are commits and merges all over the place, squash them down into fewer commits.
39+
40+
* **Conform to the code style**
41+
It's easy, just look around!
42+
43+
* **Write good commit messages**
44+
You may prefer [Tim Pope's style], you might like the [commitizen-friendly] way. Regardless of the color you pick, you MUST stay within the lines!
45+
```
46+
The commit title CANNOT exceed 50 characters
47+
48+
The body of the message comes after an empty new line, and describes the
49+
changes more thoroughly. If the change is obvious and self-explanatory
50+
from the title, you can omit the body. You should describe all changes
51+
if many were made, or maybe some trickery that only code wizards can
52+
understand.
53+
54+
Be polite and wrap your lines to 72 characters, but if you prefer going
55+
to 100 characters then I guess we can't stop you.
56+
```
57+
58+
## Final Notes
59+
60+
Thanks for reading the contributing file! Have some cake! :cake:
61+
62+
[issues]: https://github.com/PhilJay/MPAndroidChart/issues
63+
[pull requests]: https://github.com/PhilJay/MPAndroidChart/pulls
64+
[GitHub Desktop]: https://desktop.github.com/
65+
[Tim Pope's style]: https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
66+
[commitizen-friendly]: https://github.com/commitizen/cz-cli

0 commit comments

Comments
 (0)