Skip to content

Bug fix in J2 plasticity routine #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2025
Merged

Bug fix in J2 plasticity routine #80

merged 2 commits into from
Sep 18, 2025

Conversation

sanathkeshav
Copy link
Member

@sanathkeshav sanathkeshav commented Sep 17, 2025 •
edited by EMMAOpenSource
Loading

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

EMMAOpenSource
EMMAOpenSource approved these changes Sep 18, 2025
View reviewed changes
Copy link
Collaborator

@EMMAOpenSource EMMAOpenSource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks alright; in the future some more documentation could go into the variable names and for nonlinear hardening, haven a function yieldstress(epsp_eq) and dyieldstress(epsp_eq) might be helpful.

@EMMAOpenSource EMMAOpenSource merged commit d99dd7f into develop Sep 18, 2025
7 checks passed
@sanathkeshav sanathkeshav deleted the bug-fix-J2plasticity branch September 18, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EMMAOpenSource EMMAOpenSource EMMAOpenSource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanathkeshav @EMMAOpenSource